Closed
Bug 1454009
Opened 6 years ago
Closed 6 years ago
jsapi-test produces too much output
Categories
(Core :: JavaScript Engine, enhancement, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
Details
Attachments
(1 file, 1 obsolete file)
3.21 KB,
patch
|
Yoric
:
review+
|
Details | Diff | Splinter Review |
The output from the jsapi-tests used to be fairly minimal (mostly pass/fail messages) but recently this increased a lot. The current measurement is ~93000 lines.
Assignee | ||
Comment 1•6 years ago
|
||
This cuts out most of it by not printing BinAST test data.
Attachment #8967776 -
Flags: review?(dteller)
Comment on attachment 8967776 [details] [diff] [review] bug1454009-quieter-jsapi-tests Review of attachment 8967776 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/frontend/BinSource-auto.cpp @@ -3064,5 @@ > MOZ_ASSERT(kind == BinKind::Block); > CheckRecursionLimit(cx_); > > MOZ_TRY(checkFields(kind, fields, { BinField::Scope, BinField::Statements })); > - fprintf(stderr, "Block: PUSH parse context\n"); Oops, good catch, thanks! However, you'll need to change this in BinSource.yaml, otherwise, the file will be regenerated with the same problem.
Attachment #8967776 -
Flags: review?(dteller) → feedback+
Updated•6 years ago
|
Priority: -- → P3
Assignee | ||
Comment 3•6 years ago
|
||
How's this? BTW shouldn't this get generated as part of the build process?
Attachment #8967776 -
Attachment is obsolete: true
Attachment #8968148 -
Flags: review?(dteller)
Comment on attachment 8968148 [details] [diff] [review] bug1454009-quieter-jsapi-tests v2 Review of attachment 8968148 [details] [diff] [review]: ----------------------------------------------------------------- Yep, lgtm. And yes, it should be part of the build system. Once the build system is fixed to let us run Rust binaries during build-time. I have investigated this, and it doesn't work yet.
Attachment #8968148 -
Flags: review?(dteller) → review+
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5ace55927125 Cut down BinAST log output during jsapi tests r=yoric
Comment 6•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5ace55927125
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•