Closed
Bug 1454012
Opened 6 years ago
Closed 6 years ago
Follow-ups after removing the old console frontend
Categories
(DevTools :: Console, enhancement)
DevTools
Console
Tracking
(firefox61 fixed)
RESOLVED
FIXED
Firefox 61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: bgrins, Assigned: bgrins)
References
Details
Attachments
(3 files)
From https://bugzilla.mozilla.org/show_bug.cgi?id=1381834#c6: > I might have missed it, but I don't think we take care of the old frontend > prefs (and the new frontend console and browserconsole) from > devtools/client/preferences/devtools-client.js ? And from: https://bugzilla.mozilla.org/show_bug.cgi?id=1381834#c7 > Should we clean devtools/shared/webconsole/server-logger-monitor.js and > devtools/shared/webconsole/server-logger.js here ? > Maybe a follow up would be better since I think there is some actor code
> And from: https://bugzilla.mozilla.org/show_bug.cgi?id=1381834#c7 > > Should we clean devtools/shared/webconsole/server-logger-monitor.js and > > devtools/shared/webconsole/server-logger.js here ? > > Maybe a follow up would be better since I think there is some actor code We have bug 1448936 for the server logging stuff.
Depends on: 1448936
Assignee | ||
Comment 2•6 years ago
|
||
Thanks, I'll grab the server logging bug separately
Assignee | ||
Comment 3•6 years ago
|
||
Another thing to remove is NEW_CONSOLE_OUTPUT_ENABLED and conditionals: https://searchfox.org/mozilla-central/search?q=NEW_CONSOLE_OUTPUT_ENABLED&path=
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 6•6 years ago
|
||
mozreview-review |
Comment on attachment 8968229 [details] Bug 1454012 - Part 2 - Remove NEW_CONSOLE_OUTPUT_ENABLED since it's now always true; https://reviewboard.mozilla.org/r/236920/#review242708 Code analysis found 2 defects in this patch: - 2 defects found by mozlint You can run this analysis locally with: - `./mach lint path/to/file` (JS/Python) If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx ::: devtools/client/webconsole/webconsole-connection-proxy.js:374 (Diff revision 1) > * @param object packet > * The message received from the server. > */ > _onFileActivity: function(type, packet) { > if (!this.webConsoleFrame || packet.from != this._consoleActor) { > return; Error: Unnecessary return statement. [eslint: no-useless-return] ::: devtools/client/webconsole/webconsole-connection-proxy.js:380 (Diff revision 1) > - this.webConsoleFrame.handleFileActivity(packet.uri); > - } > }, > _onReflowActivity: function(type, packet) { > if (!this.webConsoleFrame || packet.from != this._consoleActor) { > return; Error: Unnecessary return statement. [eslint: no-useless-return]
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 13•6 years ago
|
||
mozreview-review |
Comment on attachment 8968228 [details] Bug 1454012 - Part 1 - Remove prefs related to the old webconsole frontend; https://reviewboard.mozilla.org/r/236918/#review242890
Attachment #8968228 -
Flags: review?(nchevobbe) → review+
Comment 14•6 years ago
|
||
mozreview-review |
Comment on attachment 8968229 [details] Bug 1454012 - Part 2 - Remove NEW_CONSOLE_OUTPUT_ENABLED since it's now always true; https://reviewboard.mozilla.org/r/236920/#review242892
Attachment #8968229 -
Flags: review?(nchevobbe) → review+
Comment 15•6 years ago
|
||
mozreview-review |
Comment on attachment 8968240 [details] Bug 1454012 - Part 3 - Remove CSS that was used only for the old webconsole frontend; https://reviewboard.mozilla.org/r/236928/#review242894 great !
Attachment #8968240 -
Flags: review?(nchevobbe) → review+
Comment 16•6 years ago
|
||
Pushed by bgrinstead@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f8af99c16f99 Part 1 - Remove prefs related to the old webconsole frontend;r=nchevobbe https://hg.mozilla.org/integration/autoland/rev/8017ae522cb0 Part 2 - Remove NEW_CONSOLE_OUTPUT_ENABLED since it's now always true;r=nchevobbe https://hg.mozilla.org/integration/autoland/rev/b9566ddf50a2 Part 3 - Remove CSS that was used only for the old webconsole frontend;r=nchevobbe
Comment 17•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f8af99c16f99 https://hg.mozilla.org/mozilla-central/rev/8017ae522cb0 https://hg.mozilla.org/mozilla-central/rev/b9566ddf50a2
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•