1454012 - Follow-ups after removing the old console frontend

Status: RESOLVED FIXED

(DevTools :: Console, enhancement)

Description

[Brian Grinstead [:bgrins]]

From https://bugzilla.mozilla.org/show_bug.cgi?id=1381834#c6:
> I might have missed it, but I don't think we take care of the old frontend
> prefs (and the new frontend console and browserconsole) from
> devtools/client/preferences/devtools-client.js ?

And from: https://bugzilla.mozilla.org/show_bug.cgi?id=1381834#c7
> Should we clean devtools/shared/webconsole/server-logger-monitor.js and
> devtools/shared/webconsole/server-logger.js here ? 
> Maybe a follow up would be better since I think there is some actor code

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

> And from: https://bugzilla.mozilla.org/show_bug.cgi?id=1381834#c7
> > Should we clean devtools/shared/webconsole/server-logger-monitor.js and
> > devtools/shared/webconsole/server-logger.js here ? 
> > Maybe a follow up would be better since I think there is some actor code

We have bug 1448936 for the server logging stuff.

Comment 2

[Brian Grinstead [:bgrins]]

Thanks, I'll grab the server logging bug separately

Comment 3

[Brian Grinstead [:bgrins]]

Another thing to remove is NEW_CONSOLE_OUTPUT_ENABLED and conditionals: https://searchfox.org/mozilla-central/search?q=NEW_CONSOLE_OUTPUT_ENABLED&path=

Comment 4

[Brian Grinstead [:bgrins]]

Attachment: Bug 1454012 - Part 1 - Remove prefs related to the old webconsole frontend;

Review commit: https://reviewboard.mozilla.org/r/236918/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/236918/

Comment 5

[Brian Grinstead [:bgrins]]

Attachment: Bug 1454012 - Part 2 - Remove NEW_CONSOLE_OUTPUT_ENABLED since it's now always true;

Review commit: https://reviewboard.mozilla.org/r/236920/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/236920/

Comment 6

[Code Review Bot [:reviewbot]]

Comment on attachment 8968229 [details]
Bug 1454012 - Part 2 - Remove NEW_CONSOLE_OUTPUT_ENABLED since it's now always true;

https://reviewboard.mozilla.org/r/236920/#review242708


Code analysis found 2 defects in this patch:
 - 2 defects found by mozlint

You can run this analysis locally with:
 - `./mach lint path/to/file` (JS/Python)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: devtools/client/webconsole/webconsole-connection-proxy.js:374
(Diff revision 1)
>     * @param object packet
>     *        The message received from the server.
>     */
>    _onFileActivity: function(type, packet) {
>      if (!this.webConsoleFrame || packet.from != this._consoleActor) {
>        return;

Error: Unnecessary return statement. [eslint: no-useless-return]

::: devtools/client/webconsole/webconsole-connection-proxy.js:380
(Diff revision 1)
> -      this.webConsoleFrame.handleFileActivity(packet.uri);
> -    }
>    },
>    _onReflowActivity: function(type, packet) {
>      if (!this.webConsoleFrame || packet.from != this._consoleActor) {
>        return;

Error: Unnecessary return statement. [eslint: no-useless-return]

Comment 7

[Brian Grinstead [:bgrins]]

Attachment: Bug 1454012 - Part 3 - Remove CSS that was used only for the old webconsole frontend;

Review commit: https://reviewboard.mozilla.org/r/236928/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/236928/

Comment 8

[Brian Grinstead [:bgrins]]

Comment on attachment 8968228 [details]
Bug 1454012 - Part 1 - Remove prefs related to the old webconsole frontend;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/236918/diff/1-2/

Comment 9

[Brian Grinstead [:bgrins]]

Comment on attachment 8968229 [details]
Bug 1454012 - Part 2 - Remove NEW_CONSOLE_OUTPUT_ENABLED since it's now always true;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/236920/diff/1-2/

Comment 10

[Brian Grinstead [:bgrins]]

Comment on attachment 8968228 [details]
Bug 1454012 - Part 1 - Remove prefs related to the old webconsole frontend;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/236918/diff/2-3/

Comment 11

[Brian Grinstead [:bgrins]]

Comment on attachment 8968229 [details]
Bug 1454012 - Part 2 - Remove NEW_CONSOLE_OUTPUT_ENABLED since it's now always true;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/236920/diff/2-3/

Comment 12

[Brian Grinstead [:bgrins]]

Comment on attachment 8968240 [details]
Bug 1454012 - Part 3 - Remove CSS that was used only for the old webconsole frontend;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/236928/diff/1-2/

Comment 13

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8968228 [details]
Bug 1454012 - Part 1 - Remove prefs related to the old webconsole frontend;

https://reviewboard.mozilla.org/r/236918/#review242890

Comment 14

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8968229 [details]
Bug 1454012 - Part 2 - Remove NEW_CONSOLE_OUTPUT_ENABLED since it's now always true;

https://reviewboard.mozilla.org/r/236920/#review242892

Comment 15

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8968240 [details]
Bug 1454012 - Part 3 - Remove CSS that was used only for the old webconsole frontend;

https://reviewboard.mozilla.org/r/236928/#review242894

great !

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f8af99c16f99
Part 1 - Remove prefs related to the old webconsole frontend;r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/8017ae522cb0
Part 2 - Remove NEW_CONSOLE_OUTPUT_ENABLED since it's now always true;r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/b9566ddf50a2
Part 3 - Remove CSS that was used only for the old webconsole frontend;r=nchevobbe

Comment 17

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/f8af99c16f99
https://hg.mozilla.org/mozilla-central/rev/8017ae522cb0
https://hg.mozilla.org/mozilla-central/rev/b9566ddf50a2