Open
Bug 1454070
Opened 6 years ago
Updated 1 year ago
[wpt-sync] Sync PR 10464 - Revert "Web Animations: Fix bugs in procedure to process a keyframes argument"
Categories
(Testing :: web-platform-tests, enhancement, P4)
Testing
web-platform-tests
Tracking
(Not tracked)
NEW
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream error])
Sync web-platform-tests PR 10464 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/w3c/web-platform-tests/pull/10464 Details from upstream follow. Avi Drissman <avi@chromium.org> wrote: > Revert "Web Animations: Fix bugs in procedure to process a keyframes argument" > > This reverts commit 0ade0386aa4168b48234bc7f33d30a62140b95ea. > > Reason for revert: > Unexpected Failures: > * bindings/sequence-type.html > * custom-elements/spec/define-element.html > * external/wpt/custom-elements/CustomElementRegistry.html > > on > https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.11%20%28dbg%29/ > https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20%28dbg%29/ > > Speculatively reverting this to see if it's the cause. > > Original change's description: > > Web Animations: Fix bugs in procedure to process a keyframes argument > > > > There were three minor bugs left in the implementation: > > > > - We threw on lists-in-custom-iterators instead of just ignoring them. > > - We returned all properties on the keyframe rather than just those > > defined on the keyframe itself (e.g. we would include prototype > > properties, against spec). > > - We didn't access the properties in ascending unicode order. > > > > Bug: 827573 > > Change-Id: I213ae5b24e1f35d7f28d16625025122950a6ba88 > > Reviewed-on: https://chromium-review.googlesource.com/989261 > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > > Reviewed-by: Robert Flack <flackr@chromium.org> > > Commit-Queue: Stephen McGruer <smcgruer@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#550641} > > TBR=flackr@chromium.org,yukishiino@chromium.org,jbroman@chromium.org,haraken@chromium.org,smcgruer@chromium.org > > Change-Id: I5e8dc0c67599492bd6e90fca4a034e29e334ef88 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 827573 > Reviewed-on: https://chromium-review.googlesource.com/1012857 > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550721} >
Reporter | ||
Updated•6 years ago
|
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Reporter | ||
Comment 1•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=f3be6621fb18faef938a75ab77af3b853bcc6aff
Reporter | ||
Comment 2•6 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=08c7c01c4507c084e4b1caa0afc7b7bea9993d02
Reporter | ||
Comment 3•6 years ago
|
||
Ran 1 tests and 50 subtests OK : 1 PASS : 50
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/fb03c240a2e2 [wpt PR 10464] - Revert "Web Animations: Fix bugs in procedure to process a keyframes argument", a=testonly
Updated•1 year ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•