Closed Bug 1454073 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 10465 - Reland "Web Animations: Fix bugs in procedure to process a keyframes argument"

Categories

(Core :: DOM: Animation, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 10465 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/10465
Details from upstream follow.

Stephen McGruer <smcgruer@chromium.org> wrote:
>  Reland "Web Animations: Fix bugs in procedure to process a keyframes argument"
>  
>  This is a reland of 0ade0386aa4168b48234bc7f33d30a62140b95ea
>  
>  Original change's description:
>  > Web Animations: Fix bugs in procedure to process a keyframes argument
>  > 
>  > There were three minor bugs left in the implementation:
>  > 
>  >   - We threw on lists-in-custom-iterators instead of just ignoring them.
>  >   - We returned all properties on the keyframe rather than just those
>  >     defined on the keyframe itself (e.g. we would include prototype
>  >     properties, against spec).
>  >   - We didn't access the properties in ascending unicode order.
>  > 
>  > Bug: 827573
>  > Change-Id: I213ae5b24e1f35d7f28d16625025122950a6ba88
>  > Reviewed-on: https://chromium-review.googlesource.com/989261
>  > Reviewed-by: Kentaro Hara <haraken@chromium.org>
>  > Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
>  > Reviewed-by: Robert Flack <flackr@chromium.org>
>  > Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
>  > Cr-Commit-Position: refs/heads/master@{#550641}
>  
>  Bug: 827573
>  Change-Id: I6c49fa6ca36db16ecddfb520e0964bd231565a0b
>  
>  Reviewed-on: https://chromium-review.googlesource.com/1012897
>  WPT-Export-Revision: e400db3bccbf1e87eae9d8f8bfcf0a5b66b121e2
Component: web-platform-tests → DOM: Animation
Product: Testing → Core
Ran 1 tests and 56 subtests
OK     : 1
PASS   : 56
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5094751f1b75
[wpt PR 10465] - Reland "Web Animations: Fix bugs in procedure to process a keyframes argument", a=testonly
https://hg.mozilla.org/mozilla-central/rev/5094751f1b75
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.