Closed
Bug 1454073
Opened 6 years ago
Closed 6 years ago
[wpt-sync] Sync PR 10465 - Reland "Web Animations: Fix bugs in procedure to process a keyframes argument"
Categories
(Core :: DOM: Animation, enhancement, P4)
Core
DOM: Animation
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 10465 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/w3c/web-platform-tests/pull/10465 Details from upstream follow. Stephen McGruer <smcgruer@chromium.org> wrote: > Reland "Web Animations: Fix bugs in procedure to process a keyframes argument" > > This is a reland of 0ade0386aa4168b48234bc7f33d30a62140b95ea > > Original change's description: > > Web Animations: Fix bugs in procedure to process a keyframes argument > > > > There were three minor bugs left in the implementation: > > > > - We threw on lists-in-custom-iterators instead of just ignoring them. > > - We returned all properties on the keyframe rather than just those > > defined on the keyframe itself (e.g. we would include prototype > > properties, against spec). > > - We didn't access the properties in ascending unicode order. > > > > Bug: 827573 > > Change-Id: I213ae5b24e1f35d7f28d16625025122950a6ba88 > > Reviewed-on: https://chromium-review.googlesource.com/989261 > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > > Reviewed-by: Robert Flack <flackr@chromium.org> > > Commit-Queue: Stephen McGruer <smcgruer@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#550641} > > Bug: 827573 > Change-Id: I6c49fa6ca36db16ecddfb520e0964bd231565a0b > > Reviewed-on: https://chromium-review.googlesource.com/1012897 > WPT-Export-Revision: e400db3bccbf1e87eae9d8f8bfcf0a5b66b121e2
Reporter | ||
Updated•6 years ago
|
Component: web-platform-tests → DOM: Animation
Product: Testing → Core
Reporter | ||
Comment 1•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=d0a348eb8593b6c87c14225c51146e3b3ede1bb0
Reporter | ||
Comment 2•6 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=0f43e4a2496c668c78d54847ee00d894948ce536
Reporter | ||
Comment 3•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=a8e7dbd090ab7ba9cdebf1661cde1e68e95a688a
Reporter | ||
Comment 4•6 years ago
|
||
Ran 1 tests and 56 subtests OK : 1 PASS : 56
Reporter | ||
Comment 5•6 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=6d8697b9b080168a84906e1e0940b741a87fb27d
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5094751f1b75 [wpt PR 10465] - Reland "Web Animations: Fix bugs in procedure to process a keyframes argument", a=testonly
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5094751f1b75
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•