Closed
Bug 1454075
Opened 6 years ago
Closed 6 years ago
Polish Login btn appearance when service domain != host domain
Categories
(Tree Management :: Treeherder: Frontend, enhancement, P5)
Tree Management
Treeherder: Frontend
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jfrench, Assigned: jfrench)
Details
Attachments
(1 file)
The Login button and accompanying text never received nice styling or padding when running the standalone yarn development server via a plain `yarn start`. Although nobody sees that in production, let's improve it anyway, while also removing the apparently unused btn-right-navbar class, which I assume got purged during the React refactoring.
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → tojonmz
Status: NEW → ASSIGNED
Component: Treeherder → Treeherder: Frontend
|
||
Comment 1•6 years ago
|
||
|
|
Assignee | |
Comment 2•6 years ago
|
||
Comment on attachment 8967876 [details] [review] Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3445 For review at your leisure :)
Attachment #8967876 -
Flags: review?(cdawson)
|
||
Comment 3•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/e8c2ac2e6356c63ed7a291376001c18388959baf Bug 1454075 - Clean up login button and remove dead class (#3445)
|
||
Updated•6 years ago
|
Attachment #8967876 -
Flags: review?(cdawson) → review+
|
|
Assignee | |
Updated•6 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•