1454088 - Remove google-nocodes

Status: RESOLVED FIXED

(Firefox :: Search, enhancement, P1)

Description

[Mike Kaply [:mkaply]]

After discussions, we don't need to try to avoid sending codes for places that we don't have agreements with Google in.

So we're just going to send codes all the time and let Google discard them where necessary.

[Tracking Requested - why for this release]: Needed to simplify search.

This will actually be a very isolated change (list.json only).

Comment 1

[Mark Banner (:standard8)]

Note: the follow-on search add-on also references google-nocodes:

https://searchfox.org/mozilla-central/search?q=google-nocodes&case=false&regexp=false&path=

Comment 2

[Mike Kaply [:mkaply]]

Attachment: Bug 1454088 - Remove use of google-nocodes.

Review commit: https://reviewboard.mozilla.org/r/239090/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/239090/

Comment 3

[Florian Quèze [:florian]]

(In reply to Mike Kaply [:mkaply] from comment #0)

> So we're just going to send codes all the time and let Google discard them
> where necessary.

Is this going to cause issues for the telemetry data we collect about search volume / our metrics people?

> This will actually be a very isolated change (list.json only).

Why is this not removing the file of the search plugin?

Comment 4

[Mike Kaply [:mkaply]]

> Is this going to cause issues for the telemetry data we collect about search volume / our metrics people?

That's a good question. I'll leave that to mconnor.

> Why is this not removing the file of the search plugin?

I had removed it locally but forgot it in the patch.

Comment 5

[Mark Banner (:standard8)]

Hmm, does this also potentially "fix" bug 1315953?

Comment 6

[Florian Quèze [:florian]]

(In reply to Mike Kaply [:mkaply] from comment #0)
> After discussions, we don't need to try to avoid sending codes for places
> that we don't have agreements with Google in.

Does this imply changes to the add-on we made for bug 1454443? Should we now insert the client codes in cases where the current Google plugin had no client parameter at all?

Comment 7

[Mike Kaply [:mkaply]]

> Does this imply changes to the add-on we made for bug 1454443? Should we now insert the client codes in cases where the current Google plugin had no client parameter at all?

I'm already doing that.

Comment 8

[Florian Quèze [:florian]]

Comment on attachment 8970293 [details]
Bug 1454088 - Remove use of google-nocodes.

https://reviewboard.mozilla.org/r/239090/#review245766

r- because this should remove the .xml file. I could r+ without a final answer on the telemetry question, but it should be answered before landing.

Comment 9

[Mike Kaply [:mkaply]]

Comment on attachment 8970293 [details]
Bug 1454088 - Remove use of google-nocodes.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/239090/diff/1-2/

Comment 10

[Mike Kaply [:mkaply]]

Mark:

I removed the engine as Florian requested.

I also verified with mconnor that this won't affect telemetry (we are already exclusing the proper regions).

Comment 11

[Mark Banner (:standard8)]

Redirected to Drew as I'm out until Tuesday.

Comment 12

[Drew Willcoxon :adw]

Comment on attachment 8970293 [details]
Bug 1454088 - Remove use of google-nocodes.

https://reviewboard.mozilla.org/r/239090/#review247632

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4f8e54f8415e
Remove use of google-nocodes. r=adw

Comment 14

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/4f8e54f8415e