Closed Bug 1454088 Opened 2 years ago Closed 2 years ago

Remove google-nocodes

Categories

(Firefox :: Search, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 61
Tracking Status
firefox60 - wontfix
firefox61 --- fixed

People

(Reporter: mkaply, Assigned: mkaply)

References

Details

Attachments

(1 file)

After discussions, we don't need to try to avoid sending codes for places that we don't have agreements with Google in.

So we're just going to send codes all the time and let Google discard them where necessary.

[Tracking Requested - why for this release]: Needed to simplify search.

This will actually be a very isolated change (list.json only).
Note: the follow-on search add-on also references google-nocodes:

https://searchfox.org/mozilla-central/search?q=google-nocodes&case=false&regexp=false&path=
Assignee: nobody → mozilla
Priority: -- → P1
Blocks: 1456236
(In reply to Mike Kaply [:mkaply] from comment #0)

> So we're just going to send codes all the time and let Google discard them
> where necessary.

Is this going to cause issues for the telemetry data we collect about search volume / our metrics people?

> This will actually be a very isolated change (list.json only).

Why is this not removing the file of the search plugin?
> Is this going to cause issues for the telemetry data we collect about search volume / our metrics people?

That's a good question. I'll leave that to mconnor.

> Why is this not removing the file of the search plugin?

I had removed it locally but forgot it in the patch.
Flags: needinfo?(mconnor)
Hmm, does this also potentially "fix" bug 1315953?
(In reply to Mike Kaply [:mkaply] from comment #0)
> After discussions, we don't need to try to avoid sending codes for places
> that we don't have agreements with Google in.

Does this imply changes to the add-on we made for bug 1454443? Should we now insert the client codes in cases where the current Google plugin had no client parameter at all?
> Does this imply changes to the add-on we made for bug 1454443? Should we now insert the client codes in cases where the current Google plugin had no client parameter at all?

I'm already doing that.
Comment on attachment 8970293 [details]
Bug 1454088 - Remove use of google-nocodes.

https://reviewboard.mozilla.org/r/239090/#review245766

r- because this should remove the .xml file. I could r+ without a final answer on the telemetry question, but it should be answered before landing.
Attachment #8970293 - Flags: review?(florian) → review-
Mark:

I removed the engine as Florian requested.

I also verified with mconnor that this won't affect telemetry (we are already exclusing the proper regions).
Flags: needinfo?(mconnor)
Status: NEW → ASSIGNED
Attachment #8970293 - Flags: review?(standard8) → review?(adw)
Redirected to Drew as I'm out until Tuesday.
Comment on attachment 8970293 [details]
Bug 1454088 - Remove use of google-nocodes.

https://reviewboard.mozilla.org/r/239090/#review247632
Attachment #8970293 - Flags: review?(adw) → review+
Pushed by mozilla@kaply.com:
https://hg.mozilla.org/integration/autoland/rev/4f8e54f8415e
Remove use of google-nocodes. r=adw
https://hg.mozilla.org/mozilla-central/rev/4f8e54f8415e
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
You need to log in before you can comment on or make changes to this bug.