Closed Bug 1454123 Opened 2 years ago Closed 2 years ago

Intermittent devtools/client/webconsole/test/mochitest/browser_webconsole_split.js | The menu item indicates the console is not split - Got undefined, expected split

Categories

(DevTools :: Console, defect, P5)

defect

Tracking

(firefox61 wontfix, firefox62 fixed)

RESOLVED FIXED
Firefox 62
Tracking Status
firefox61 --- wontfix
firefox62 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: mantaroh)

References

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell fixed:timing])

Attachments

(4 files, 5 obsolete files)

Filed by: apavel [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=173632023&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/d3-PmW29R_Sdf8FT1Bpprg/runs/0/artifacts/public/logs/live_backing.log

23:36:10     INFO -  820 INFO Testing host types
23:36:10     INFO -  821 INFO TEST-PASS | devtools/client/webconsole/test/mochitest/browser_webconsole_split.js | host type is bottom -
23:36:10     INFO -  822 INFO TEST-PASS | devtools/client/webconsole/test/mochitest/browser_webconsole_split.js | host pref is bottom -
23:36:10     INFO -  823 INFO TEST-PASS | devtools/client/webconsole/test/mochitest/browser_webconsole_split.js | Splitter is hidden by default -
23:36:10     INFO -  824 INFO TEST-PASS | devtools/client/webconsole/test/mochitest/browser_webconsole_split.js | Deck has a height > 0 by default -
23:36:10     INFO -  825 INFO TEST-PASS | devtools/client/webconsole/test/mochitest/browser_webconsole_split.js | Web console is collapsed by default -
23:36:10     INFO -  826 INFO TEST-PASS | devtools/client/webconsole/test/mochitest/browser_webconsole_split.js | The console panel is not the current tool -
23:36:10     INFO -  827 INFO TEST-PASS | devtools/client/webconsole/test/mochitest/browser_webconsole_split.js | The menu item indicates the console is not split -
23:36:10     INFO -  828 INFO TEST-PASS | devtools/client/webconsole/test/mochitest/browser_webconsole_split.js | Splitter is visible when console is split -
23:36:10     INFO -  829 INFO TEST-PASS | devtools/client/webconsole/test/mochitest/browser_webconsole_split.js | Deck has a height > 0 when console is split -
23:36:10     INFO -  830 INFO TEST-PASS | devtools/client/webconsole/test/mochitest/browser_webconsole_split.js | Web console has a height > 0 when console is split -
23:36:10     INFO -  831 INFO TEST-PASS | devtools/client/webconsole/test/mochitest/browser_webconsole_split.js | Everything adds up to container height -
23:36:10     INFO -  832 INFO TEST-PASS | devtools/client/webconsole/test/mochitest/browser_webconsole_split.js | The console panel is not the current tool -
23:36:10     INFO -  833 INFO TEST-PASS | devtools/client/webconsole/test/mochitest/browser_webconsole_split.js | The menu item indicates the console is split -
23:36:10     INFO -  834 INFO TEST-PASS | devtools/client/webconsole/test/mochitest/browser_webconsole_split.js | host type is side -
23:36:10     INFO -  835 INFO TEST-PASS | devtools/client/webconsole/test/mochitest/browser_webconsole_split.js | host pref is side -
23:36:10     INFO -  836 INFO TEST-PASS | devtools/client/webconsole/test/mochitest/browser_webconsole_split.js | Splitter is hidden after toggling -
23:36:10     INFO -  837 INFO TEST-PASS | devtools/client/webconsole/test/mochitest/browser_webconsole_split.js | Deck has a height > 0 after toggling -
23:36:10     INFO -  838 INFO TEST-PASS | devtools/client/webconsole/test/mochitest/browser_webconsole_split.js | Web console is collapsed after toggling -
23:36:10     INFO -  839 INFO TEST-PASS | devtools/client/webconsole/test/mochitest/browser_webconsole_split.js | The console panel is not the current tool -
23:36:10     INFO -  840 INFO TEST-PASS | devtools/client/webconsole/test/mochitest/browser_webconsole_split.js | The menu item indicates the console is not split -
23:36:10     INFO -  841 INFO TEST-PASS | devtools/client/webconsole/test/mochitest/browser_webconsole_split.js | host type is window -
23:36:10     INFO -  842 INFO TEST-PASS | devtools/client/webconsole/test/mochitest/browser_webconsole_split.js | host pref is window -
23:36:10     INFO -  843 INFO TEST-PASS | devtools/client/webconsole/test/mochitest/browser_webconsole_split.js | Splitter is hidden by default -
23:36:10     INFO -  844 INFO TEST-PASS | devtools/client/webconsole/test/mochitest/browser_webconsole_split.js | Deck has a height > 0 by default -
23:36:10     INFO -  845 INFO TEST-PASS | devtools/client/webconsole/test/mochitest/browser_webconsole_split.js | Web console is collapsed by default -
23:36:10     INFO -  846 INFO TEST-PASS | devtools/client/webconsole/test/mochitest/browser_webconsole_split.js | The console panel is not the current tool -
23:36:10     INFO -  Buffered messages finished
23:36:10    ERROR -  847 INFO TEST-UNEXPECTED-FAIL | devtools/client/webconsole/test/mochitest/browser_webconsole_split.js | The menu item indicates the console is not split - Got undefined, expected split
23:36:10     INFO -  Stack trace:
23:36:10     INFO -  chrome://mochikit/content/browser-test.js:test_is:1280
23:36:10     INFO -  chrome://mochitests/content/browser/devtools/client/webconsole/test/mochitest/browser_webconsole_split.js:checkToolboxUI:192
23:36:11     INFO -  848 INFO Leaving test bound
23:36:11     INFO -  849 INFO Removing tab.
23:36:11     INFO -  850 INFO Waiting for event: 'TabClose' on [object XULElement].
23:36:11     INFO -  851 INFO Got event: 'TabClose' on [object XULElement].
23:36:11     INFO -  852 INFO Tab removed and finished closing
23:36:11     INFO -  GECKO(7420) | MEMORY STAT | vsize 2105300MB | vsizeMaxContiguous 129452100MB | residentFast 419MB | heapAllocated 187MB
See Also: → 1452424
There are 32 failures in the past 7 days.
Platforms: windows7-32-nightly opt, windows10-64 pgo/ opt, Windows 7 pgo, OS X 10.10 opt
Recent log failure: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=174917484&lineNumber=3435

Relevant part of the log:
07:48:58    ERROR -  763 INFO TEST-UNEXPECTED-FAIL | devtools/client/webconsole/test/mochitest/browser_webconsole_split.js | The menu item indicates the console is not split - Got undefined, expected split
07:48:58     INFO -  Stack trace:
07:48:58     INFO -  chrome://mochikit/content/browser-test.js:test_is:1285
07:48:58     INFO -  chrome://mochitests/content/browser/devtools/client/webconsole/test/mochitest/browser_webconsole_split.js:checkToolboxUI:192
07:48:58     INFO -  764 INFO Leaving test bound
07:48:59     INFO -  765 INFO Removing tab.
07:48:59     INFO -  766 INFO Waiting for event: 'TabClose' on [object XULElement].
07:48:59     INFO -  767 INFO Got event: 'TabClose' on [object XULElement].
07:48:59     INFO -  768 INFO Tab removed and finished closing
07:48:59     INFO -  GECKO(700) | MEMORY STAT | vsize 2105283MB | vsizeMaxContiguous 129513466MB | residentFast 390MB | heapAllocated 174MB
07:48:59     INFO -  769 INFO TEST-OK | devtools/client/webconsole/test/mochitest/browser_webconsole_split.js | took 4619ms
07:48:59     INFO -  770 INFO checking window state

:bgrins Can you please take a look here?
Flags: needinfo?(bgrinstead)
Whiteboard: [stockwell needswork]
Copying over blocking and needinfo fields from Bug 1452424 as per https://bugzilla.mozilla.org/show_bug.cgi?id=1452424#c6. We were originally thinking this was limited to the old console (see Comments 7-9 on that bug), but unfortunately it wasn't.
Blocks: 1444301
Flags: needinfo?(bgrinstead) → needinfo?(bbirtles)
The problem seems to be reading the menu label when the host type is window. It also seems to only happen on Windows / Mac.

We're getting back an undefined label and there doesn't seem to be any timeout happening so, looking at the following bit of code...

> function getMenuLabel() {
>   return new Promise(resolve => {
>     const button = toolbox.doc.getElementById("toolbox-meatball-menu-button");
>     EventUtils.sendMouseEvent({ type: "click" }, button);
>
>     toolbox.doc.addEventListener("popupshown", () => {
>       const menuItem =
>         toolbox.doc.getElementById("toolbox-meatball-menu-splitconsole");
>
>       // Return undefined if the menu item is not available
>       let label;
>       if (menuItem) {
>         label = ...
>       }
>
>       // Wait for menu to close
>       toolbox.doc.addEventListener("popuphidden", () => {
>         resolve(label);
>       }, { once: true });
> ...

...my initial guess here was that there's some conflict between spawning the new window and triggering the menu. For example, perhaps we trigger the menu while the new window is loading, queue the "popupshown" event, but, as part of initializing and assigning focus to the new window, the autohide behavior of the menu is triggered. As a result when the "popupshown" event is processed but at that point the 'toolbox-meatball-menu-splitconsole' element is no longer available?

However, I managed to reproduce this once on Windows with an 'else' block for when menuItem is falsey and we didn't seem to hit it. According to orangefactor it seems to reproduce more frequently on Mac so I'll try there too.
Flags: needinfo?(bbirtles)
I've tried 100s of times on Windows and Mac to reproduce this without success. Time to start debugging this on try.
(In reply to Brian Birtles (:birtles) from comment #5)
> However, I managed to reproduce this once on Windows with an 'else' block
> for when menuItem is falsey and we didn't seem to hit it.

Actually we do hit it. From the log on try:

> 05:16:26     INFO -  746 INFO BB: popupshown
> 05:16:26     INFO -  747 INFO BB: popuphidden
> 05:16:26     INFO -  748 INFO TEST-PASS | devtools/client/webconsole/test/mochitest/browser_webconsole_split.js | Splitter is hidden after toggling -
> 05:16:26     INFO -  749 INFO TEST-PASS | devtools/client/webconsole/test/mochitest/browser_webconsole_split.js | Deck has a height > 0 after toggling -
> 05:16:26     INFO -  750 INFO TEST-PASS | devtools/client/webconsole/test/mochitest/browser_webconsole_split.js | Web console is collapsed after toggling -
> 05:16:26     INFO -  751 INFO TEST-PASS | devtools/client/webconsole/test/mochitest/browser_webconsole_split.js | The console panel is not the current tool -
> 05:16:26     INFO -  752 INFO TEST-PASS | devtools/client/webconsole/test/mochitest/browser_webconsole_split.js | The menu item indicates the console is not split -
> 05:16:26     INFO -  753 INFO BB: popupshown
> 05:16:26     INFO -  754 INFO BB: Couldn't find menuItem
> 05:16:26     INFO -  755 INFO BB: Documentation item? null
> 05:16:26     INFO -  756 INFO TEST-PASS | devtools/client/webconsole/test/mochitest/browser_webconsole_split.js | host type is window -
> 05:16:26     INFO -  757 INFO TEST-PASS | devtools/client/webconsole/test/mochitest/browser_webconsole_split.js | host pref is window -
> 05:16:26     INFO -  758 INFO BB: popuphidden
> 05:16:26     INFO -  759 INFO TEST-PASS | devtools/client/webconsole/test/mochitest/browser_webconsole_split.js | Splitter is hidden by default -
> 05:16:26     INFO -  760 INFO TEST-PASS | devtools/client/webconsole/test/mochitest/browser_webconsole_split.js | Deck has a height > 0 by default -
> 05:16:26     INFO -  761 INFO TEST-PASS | devtools/client/webconsole/test/mochitest/browser_webconsole_split.js | Web console is collapsed by default -
> 05:16:26     INFO -  762 INFO TEST-PASS | devtools/client/webconsole/test/mochitest/browser_webconsole_split.js | The console panel is not the current tool -
> 05:16:26     INFO -  Buffered messages finished
> 05:16:26    ERROR -  763 INFO TEST-UNEXPECTED-FAIL | devtools/client/webconsole/test/mochitest/browser_webconsole_split.js | The menu item indicates the console is not split - Got undefined, expected split

The `Documentation item? null` part indicates that the menu has been closed at this point (or simply never shown and `popupshown` is lying).

So far my initial guess about some interaction causing the menupopup to be hidden seems plausible.

In terms of fixes I guess we can either:

1) Wait longer before trying to open the menu.
2) Test if the menu is open before trying to fetch the label of one of its items, and if it's not, re-try opening it.

(2) sounds quite involved and potentially flaky.

For (1), however, I'm not sure what to wait on. Just wait on idle? Orangefactor suggests this is only happening on opt builds so presumably any additional wait would help but it would be nice to wait on something more reliable than just an idle callback.
(In reply to Brian Birtles (:birtles) from comment #7)
> In terms of fixes I guess we can either:
> 
> 1) Wait longer before trying to open the menu.
> ...
> For (1), however, I'm not sure what to wait on. Just wait on idle?
> Orangefactor suggests this is only happening on opt builds so presumably any
> additional wait would help but it would be nice to wait on something more
> reliable than just an idle callback.

I can't find anything else obvious to wait on here. Trying to wait on idle:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a3cfe775e4456675dada22653453ba835097017e
Not all the try jobs have run yet (they're just sitting there pending :/ ) but so far this looks promising so I'm optimistically putting this up for review.
Assignee: nobody → bbirtles
Status: NEW → ASSIGNED
(In reply to Brian Birtles (:birtles) from comment #9)
> Not all the try jobs have run yet (they're just sitting there pending :/ )
> but so far this looks promising so I'm optimistically putting this up for
> review.

The remaining try jobs have run and this seems to fix the problem.
Comment on attachment 8970762 [details]
Bug 1454123 - Wait a moment after moving toolbox to a window before triggering its menu;

https://reviewboard.mozilla.org/r/239518/#review245212

Seems fine to me if it fixes the intermittent
Attachment #8970762 - Flags: review?(bgrinstead) → review+
Pushed by bbirtles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dd82a78059af
Wait a moment after moving toolbox to a window before triggering its menu; r=bgrins
https://hg.mozilla.org/mozilla-central/rev/dd82a78059af
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Backout by aiakab@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/99c19a66c3a2
Backed out changeset dd82a78059af for devtools failures at devtools/client/webconsole/test/mochitest/browser_webconsole_split.js a=backout
Backed out changeset dd82a78059af (bug 1454123) for devtools failures at devtools/client/webconsole/test/mochitest/browser_webconsole_split.js a=backout
Link to a log:https://treeherder.mozilla.org/logviewer.html#?job_id=175619483&repo=mozilla-central
Backout revision https://hg.mozilla.org/mozilla-central/rev/99c19a66c3a2fbf8108d4b8a161cded31e948409
Failing push:https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=a83a4ef50f6ca754ec451320dfefbffa707bad1a&filter-searchStr=devtools&filter-failure_classification_id=2
Status: RESOLVED → REOPENED
Flags: needinfo?(bbirtles)
Resolution: FIXED → ---
Target Milestone: Firefox 61 → ---
https://hg.mozilla.org/mozilla-central/rev/99c19a66c3a2
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: Firefox 61 → ---
I'm not sure backing out was a good idea. That patch should have made the failure less frequent at least.
Flags: needinfo?(bbirtles)
Pushed by dluca@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/595101eb4739
Wait a moment after moving toolbox to a window before triggering its menu; r=bgrins
https://hg.mozilla.org/mozilla-central/rev/595101eb4739
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Re-opening this because comment 16 suggests this can still happen. In my testing, however, the patch I produced should mitigate it to some degree. We'll see how it behaves over the next few days to see how effective that mitigation has been.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Over the last 7 days there are 33 failures present on this bug. Most of them happen on windows10-64, Windows 7 and OS X 10.10

Here is the most recent log example: https://treeherder.mozilla.org/logviewer.html#?repo=autoland&job_id=176896081&lineNumber=4726

05:39:25     INFO -  Buffered messages finished
05:39:25    ERROR -  793 INFO TEST-UNEXPECTED-FAIL | devtools/client/webconsole/test/mochitest/browser_webconsole_split.js | The menu item indicates the console is not split - Got undefined, expected split
05:39:25     INFO -  Stack trace:
05:39:25     INFO -  chrome://mochikit/content/browser-test.js:test_is:1290
05:39:25     INFO -  chrome://mochitests/content/browser/devtools/client/webconsole/test/mochitest/browser_webconsole_split.js:checkToolboxUI:200
Flags: needinfo?(bbirtles)
Attached patch Disabled test on Win (obsolete) — Splinter Review
Disabled the test only on win, as the frequency rate on OS X is lower. 
Please take a look, thanks.
Attachment #8973503 - Flags: review?(jmaher)
Comment on attachment 8973503 [details] [diff] [review]
Disabled test on Win

Review of attachment 8973503 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for this patch, can you try one more time with the small changes.  Also change the commit message to mention !debug:
Bug 1454123 - disabled browser_webconsole_split.js on Win opt for frequent failures r=jmaher

::: devtools/client/webconsole/test/mochitest/browser.ini
@@ +341,4 @@
>  [browser_webconsole_sourcemap_invalid.js]
>  [browser_webconsole_sourcemap_nosource.js]
>  [browser_webconsole_split.js]
> +skip-if = os == 'win' && !debug #Bug 1454123 disabled on Win for frequent failrues

2 nits:
1) fix typo in the last word: failures
2) add a space between #Bug -> # Bug
Attachment #8973503 - Flags: review?(jmaher) → review-
Done the requested modifications, please take a look. 
Thanks,
Attachment #8973506 - Flags: review?(jmaher)
Attachment #8973503 - Attachment is obsolete: true
Comment on attachment 8973506 [details] [diff] [review]
Disabled on win !debug

Review of attachment 8973506 [details] [diff] [review]:
-----------------------------------------------------------------

excellent
Attachment #8973506 - Flags: review?(jmaher) → review+
Whiteboard: [stockwell disable-recommended] → [stockwell disabled]
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1525ef29ed01
disabled browser_webconsole_split.js on Win !debug for frequent failures r=jmaher
Keywords: checkin-needed
This is tough. There's some OS-specific interaction happening here that we need to wait for but there's nothing obvious to wait on. Perhaps I can try approach #2 from comment 7.
In the last 2 days there are no new failures on this bug.
Hi, this started to have again a high occurance rate on autoland, on OS X, starting with this push https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=fd84333ffe760d3fdb151e2d79316c69743f3129&selectedJob=178629355 

It currently has 27 failures starting last night, appearing on every push since ^ and moving chunks. Joel, should we consider disabling it on OS X?
Flags: needinfo?(jmaher)
:apavel, thanks for looking into this- yes, lets disable this on osx if it is perma failing.
Flags: needinfo?(jmaher)
Attached patch Disalbed test on OS X (obsolete) — Splinter Review
Attachment #8976065 - Flags: review?(jmaher)
Comment on attachment 8976065 [details] [diff] [review]
Disalbed test on OS X

Review of attachment 8976065 [details] [diff] [review]:
-----------------------------------------------------------------

thanks, this looks good
Attachment #8976065 - Flags: review?(jmaher) → review+
Target Milestone: Firefox 61 → ---
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ae10e83d1e39
disabled browser_webconsole_split.js on OS X for frequent failures r=jmaher
Keywords: checkin-needed
Fail didn`t skip OS.X
Modified the patch to skip it on OS.X and Linux64:
- Added Linux64 !debug because there are 22 failures in the last 7 days
- Removed "win" because in the last 7 days there are 9 failures on Win10 and 11 on Win7. We`ll disable on "win" if the fail rate will increase.
Attachment #8976065 - Attachment is obsolete: true
Flags: needinfo?(jmaher)
Attachment #8976417 - Flags: review?(jmaher)
Comment on attachment 8976417 [details] [diff] [review]
Disable test on OS X and Linux 64

Review of attachment 8976417 [details] [diff] [review]:
-----------------------------------------------------------------

good fix on the mac instead of osx.  I would like to add windows.

::: devtools/client/webconsole/test/mochitest/browser.ini
@@ +341,4 @@
>  [browser_webconsole_sourcemap_invalid.js]
>  [browser_webconsole_sourcemap_nosource.js]
>  [browser_webconsole_split.js]
> +skip-if = (os == 'mac') || (os == 'linux' && !debug && bits == 64) # Bug 1454123 disabled on OS X and Linux64 for frequent failures

I would still like windows to be removed primarily because that is 20 failures in the last week that we could be removing.  Maybe |os == "win" && !debug| ?
Attachment #8976417 - Flags: review?(jmaher) → review-
Modified the patch to skip the test on Windows debug too
Attachment #8976417 - Attachment is obsolete: true
Attachment #8976473 - Flags: review?(jmaher)
Attached patch Disable1454123_6.patch (obsolete) — Splinter Review
Attachment #8976473 - Attachment is obsolete: true
Attachment #8976477 - Attachment is obsolete: true
Attachment #8976473 - Flags: review?(jmaher)
Attachment #8976478 - Flags: review?(jmaher)
Comment on attachment 8976478 [details] [diff] [review]
Disable test on OS X, Windows and Linux 64

Review of attachment 8976478 [details] [diff] [review]:
-----------------------------------------------------------------

this looks good
Attachment #8976478 - Flags: review?(jmaher) → review+
Flags: needinfo?(jmaher)
Keywords: checkin-needed
Pushed by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/48fa7c16ddc7
Disable browser_webconsole_split.js for frequent failures on OS X, Windows and Linux64. r=jmaher
Keywords: checkin-needed
Blocks: 1461985
I encountered this test failure on yesterday.
I think we will need to wait for the checkToolboxUI function due to ensure to toggle split console. Furthermore, we should send "ESCAPE" key code to target window because of test the WINDOW host type.

https://searchfox.org/mozilla-central/rev/da499aac682d0bbda5829327b60a865cbc491611/devtools/client/webconsole/test/mochitest/browser_webconsole_split.js#27,30,41
https://searchfox.org/mozilla-central/rev/da499aac682d0bbda5829327b60a865cbc491611/devtools/client/webconsole/test/mochitest/browser_webconsole_split.js#119
I applied mantaroh's patch and both --run-until-failure and --verify runs come green, when they use to fail quite fast.
Thanks Mantaroh !
(In reply to Nicolas Chevobbe [:nchevobbe] from comment #54)
> I applied mantaroh's patch and both --run-until-failure and --verify runs
> come green, when they use to fail quite fast.
> Thanks Mantaroh !

Thank you for your information!

Birtles tried 130 times to the same test on try server, however, this intermittent test failure has occurred. I want to more confirm this test on try server to make sure this fix is effective.
Comment on attachment 8979138 [details]
Bug 1454123 - Wait for checkToolboxUI and send the key event to the target window.

https://reviewboard.mozilla.org/r/245380/#review251278

Looks good to me if this fixes the intermittent. Thanks!
Attachment #8979138 - Flags: review?(bbirtles) → review+
Flags: needinfo?(bbirtles)
Comment on attachment 8979138 [details]
Bug 1454123 - Wait for checkToolboxUI and send the key event to the target window.

https://reviewboard.mozilla.org/r/245380/#review251278

Thank you for the review.
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 17a862bd9aecf4af31f55e52a15968f882f7da72 -d 2af84ea1c49d: rebasing 464372:17a862bd9aec "Bug 1454123 - Wait for checkToolboxUI and send the key event to the target window. r=birtles" (tip)
merging devtools/client/webconsole/test/mochitest/browser.ini
warning: conflicts while merging devtools/client/webconsole/test/mochitest/browser.ini! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
(In reply to Mozilla Autoland from comment #60)
> We're sorry, Autoland could not rebase your commits for you automatically.
> Please manually rebase your commits and try again.
> 
> hg error in cmd: hg rebase -s 17a862bd9aecf4af31f55e52a15968f882f7da72 -d
> 2af84ea1c49d: rebasing 464372:17a862bd9aec "Bug 1454123 - Wait for
> checkToolboxUI and send the key event to the target window. r=birtles" (tip)
> merging devtools/client/webconsole/test/mochitest/browser.ini
> warning: conflicts while merging
> devtools/client/webconsole/test/mochitest/browser.ini! (edit, then use 'hg
> resolve --mark')
> unresolved conflicts (see hg resolve, then hg rebase --continue)

Oh, this conflict depends on my previous commit(Bug 1444302). So I'll land this after bug 1444302 is merged to m-c.
(In reply to Mantaroh Yoshinaga[:mantaroh] from comment #63)
> Comment on attachment 8979138 [details]
> Bug 1454123 - Wait for checkToolboxUI and send the key event to the target
> window.
> 
> Review request updated; see interdiff:
> https://reviewboard.mozilla.org/r/245380/diff/1-2/

This change merged the bug 1444302 to this patch.
Pushed by mantaroh@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c4e2996db71b
Wait for checkToolboxUI and send the key event to the target window. r=birtles
As best I can tell this is fixed by Mantaroh's patch.
Assignee: bbirtles → mantaroh
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Whiteboard: [stockwell disabled] → [stockwell fixed]
There were no occurrences since the 22nd of May.
Keywords: leave-open
Whiteboard: [stockwell fixed] → [stockwell fixed:timing]
Target Milestone: --- → Firefox 62
Duplicate of this bug: 1452379
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.