1454147 - Search box placeholder text incorrectly aligned for te.wikipedia.org

Status: RESOLVED WORKSFORME

(Core :: Layout: Text and Fonts, defect)

Description

[arjuna rao chavala]

Attachment: Incorrectly offset search text placeholder in firefox

Search box placeholder text incorrectly aligned for te.wikipedia.org. (Screenshot enclosed). The problem not observed on Chrome.(Screenshot enclosed).

This type of misalignment of tool bar is observed when editing page as well

Comment 1

[arjuna rao chavala]

Attachment: correct placeholder text on chrome in searchbox

Chrome screenshot enclosed.

Comment 2

[arjuna rao chavala]

URL for screenshot: https://te.wikipedia.org/wiki/%E0%B0%AE%E0%B1%8A%E0%B0%A6%E0%B0%9F%E0%B0%BF_%E0%B0%AA%E0%B1%87%E0%B0%9C%E0%B1%80

Comment 3

[arjuna rao chavala]

A bug filed with mediawiki for the same issue, which could be of help to resolve is given here. https://bugzilla.mozilla.org/show_bug.cgi?id=1454147

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to arjuna rao chavala from comment #3)
> A bug filed with mediawiki for the same issue, which could be of help to
> resolve is given here. https://bugzilla.mozilla.org/show_bug.cgi?id=1454147

You have provided a link to this bug instead of the mediawiki bug you mentioned. Could you post that link instead?

Comment 5

[arjuna rao chavala]

(In reply to Panos Astithas [:past] (please ni?) from comment #4)
> (In reply to arjuna rao chavala from comment #3)
> > A bug filed with mediawiki for the same issue, which could be of help to
> > resolve is given here. https://bugzilla.mozilla.org/show_bug.cgi?id=1454147
> 
> You have provided a link to this bug instead of the mediawiki bug you
> mentioned. Could you post that link instead?
Sorry. Here it is.

https://phabricator.wikimedia.org/T192247

Comment 6

[Xidorn Quan [:xidorn] UTC+10]

I cannot reproduce this on macOS. It's probably specific to Linux? And it is also possible specific to some font used in that platform...

Comment 7

[arjuna rao chavala]

I tried different fonts and found the incorrect rendering. It seems specific to Ubuntu version of firefox. Any tips to debug could help, as I hate to have an unpleasant browsing experience with Firefox.

Comment 8

[Xidorn Quan [:xidorn] UTC+10]

OK, I can reproduce this on Ubuntu... The issue seems to be that the <input> element is shifted downward from where it should be.

Looking at the styles I cannot make sense of how this happens... Everything looks so normal.

I tried to change the display of the <input> to block instead, and that fixes this problem. Other values like inline or inline-block would have this issue. That probably means it is an issue in vertical alignment code in line layout.

Comment 9

[Xidorn Quan [:xidorn] UTC+10]

Attachment: reduced testcase

This can be reproduced on Windows and Ubuntu with this testcase and latest Lohit Telugu font.

Comment 10

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Lohit-Telugu.ttf

This is the font can be used with the testcase to reproduce this issue. It is downloaded from https://releases.pagure.org/lohit/lohit-telugu-ttf-2.5.5.tar.gz

Comment 11

[Jonathan Kew [:jfkthame]]

That Lohit Telugu font has some unusually large metrics in the <hhea> table:

  <hhea>
    <tableVersion value="0x00010000"/>
    <ascent value="999"/>
    <descent value="-674"/>
    <lineGap value="200"/>

This is with a unitsPerEm of 1024, so according to these figures, its "expected" line height would be about 1.83em, which is much larger than most fonts (around 1.1-1.2em would be more typical).

The alternative (preferred) "typographic" metrics in the OS/2 table are even more extreme:

  <OS_2>
    ...
    <sTypoAscender value="1617"/>
    <sTypoDescender value="-784"/>
    <sTypoLineGap value="20"/>

implying an expected default line height of around 2.36em, for a browser that uses these metrics as the basis for its calculations. (IIRC, Firefox behavior may currently differ between platforms, for various legacy reasons. But either way, the font's extremely large line-spacing metrics are probably at the root of this.)

Comment 12

[arjuna rao chavala]

The problem disappeared somehow on my system. Will update If I notice it again.

Comment 13

[Jonathan Kew [:jfkthame]]

Thanks, resolving this as WORKSFORME for now. It's possible this changed recently as a result of bug 1406552.

Comment 14

[arjuna rao chavala]

I find the version is 60.0

Comment 15

[Bartosz Dziewoński]

For future reference, this only affected Firefox 59. Firefox 58 and 60 were okay.