Closed
Bug 1454148
Opened 6 years ago
Closed 6 years ago
"View/Hide Bookmarks Toolbar" and "View/Hide Bookmarks Sidebar" items are moved too much to right
Categories
(Firefox :: Bookmarks & History, defect, P1)
Tracking
()
VERIFIED
FIXED
Firefox 61
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox59 | --- | unaffected |
firefox60 | --- | verified |
firefox61 | --- | verified |
People
(Reporter: Virtual, Assigned: Paolo)
References
(Blocks 1 open bug)
Details
(Keywords: nightly-community, regression)
Attachments
(3 files)
13.68 KB,
image/png
|
Details | |
13.60 KB,
image/png
|
Details | |
59 bytes,
text/x-review-board-request
|
Gijs
:
review+
jcristau
:
approval-mozilla-beta+
|
Details |
I'm using latest Mozilla Firefox Nightly 61.0a1 (2018-04-13) (64-bit) [rev: https://hg.mozilla.org/mozilla-central/rev/6547c27303bc4d8961b11e656751e839807d65c7 ], so it should also has patch from bug #1448822. @ :Paolo Amadini - Any ideas what's going on?
Flags: needinfo?(paolo.mozmail)
Assignee | ||
Comment 2•6 years ago
|
||
I didn't add icons for these items, but there is a missing "menuitem-iconic" class, that is used in the same menu also for items without icons.
Flags: needinfo?(paolo.mozmail)
Comment hidden (mozreview-request) |
Updated•6 years ago
|
Assignee: nobody → paolo.mozmail
Status: NEW → ASSIGNED
Priority: -- → P1
Comment 4•6 years ago
|
||
mozreview-review |
Comment on attachment 8967945 [details] Bug 1454148 - Fix class of the "View Bookmarks Toolbar" and "View Bookmarks Sidebar" items in the Bookmarks button menu. https://reviewboard.mozilla.org/r/236642/#review242432 r=me in the sense that it looks OK to me... but I haven't tested on Windows. Can we make sure we have a follow-up to add the icons for 61?
Attachment #8967945 -
Flags: review?(gijskruitbosch+bugs) → review+
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•6 years ago
|
Blocks: 1454225
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Comment 5•6 years ago
|
||
(In reply to :Gijs (he/him) from comment #4) > Can we make sure we have a follow-up to add the icons for 61? Sure, I created bug #1454225 about this.
Has Regression Range: --- → yes
Has STR: --- → irrelevant
Keywords: nightly-community
Summary: "View/Hide Bookmarks Toolbar" and "View/Hide Bookmarks Sidebar" items don't have icons and are too much moved to right → "View/Hide Bookmarks Toolbar" and "View/Hide Bookmarks Sidebar" items are moved too much to right
Pushed by paolo.mozmail@amadzone.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/c4c41983362c Fix class of the "View Bookmarks Toolbar" and "View Bookmarks Sidebar" items in the Bookmarks button menu. r=Gijs
Assignee | ||
Comment 7•6 years ago
|
||
Comment on attachment 8967945 [details] Bug 1454148 - Fix class of the "View Bookmarks Toolbar" and "View Bookmarks Sidebar" items in the Bookmarks button menu. This is part of the uplift request in bug 1391948 comment 17.
Attachment #8967945 -
Flags: approval-mozilla-beta?
Comment 8•6 years ago
|
||
Comment on attachment 8967945 [details] Bug 1454148 - Fix class of the "View Bookmarks Toolbar" and "View Bookmarks Sidebar" items in the Bookmarks button menu. css fix for bookmarks menu, approved for 60.0b13
Attachment #8967945 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
![]() |
||
Comment 9•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c4c41983362c
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Comment 10•6 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/6631c7ed99f2
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Comment 11•6 years ago
|
||
I'm confirming that bug is fixed, starting in Mozilla Firefox Nightly 61.0a1 (2018-04-16), so I'm marking this bug as VERIFIED. Same as in latest Mozilla Firefox Beta. Thanks.
You need to log in
before you can comment on or make changes to this bug.
Description
•