"View/Hide Bookmarks Toolbar" and "View/Hide Bookmarks Sidebar" items are moved too much to right

VERIFIED FIXED in Firefox 60

Status

()

defect
P1
major
VERIFIED FIXED
a year ago
a year ago

People

(Reporter: Virtual, Assigned: Paolo)

Tracking

(Blocks 1 bug, {nightly-community, regression})

61 Branch
Firefox 61
x86_64
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox59 unaffected, firefox60 verified, firefox61 verified)

Details

Attachments

(3 attachments)

Posted image 1.png
I'm using latest Mozilla Firefox Nightly 61.0a1 (2018-04-13) (64-bit) [rev: https://hg.mozilla.org/mozilla-central/rev/6547c27303bc4d8961b11e656751e839807d65c7 ], so it should also has patch from bug #1448822.

@ :Paolo Amadini - Any ideas what's going on?
Flags: needinfo?(paolo.mozmail)
(Assignee)

Comment 2

a year ago
I didn't add icons for these items, but there is a missing "menuitem-iconic" class, that is used in the same menu also for items without icons.
Flags: needinfo?(paolo.mozmail)
Assignee: nobody → paolo.mozmail
Status: NEW → ASSIGNED
Priority: -- → P1

Comment 4

a year ago
mozreview-review
Comment on attachment 8967945 [details]
Bug 1454148 - Fix class of the "View Bookmarks Toolbar" and "View Bookmarks Sidebar" items in the Bookmarks button menu.

https://reviewboard.mozilla.org/r/236642/#review242432

r=me in the sense that it looks OK to me... but I haven't tested on Windows. Can we make sure we have a follow-up to add the icons for 61?
Attachment #8967945 - Flags: review?(gijskruitbosch+bugs) → review+
(In reply to :Gijs (he/him) from comment #4)
> Can we make sure we have a follow-up to add the icons for 61?

Sure, I created bug #1454225 about this.
Has Regression Range: --- → yes
Has STR: --- → irrelevant
Summary: "View/Hide Bookmarks Toolbar" and "View/Hide Bookmarks Sidebar" items don't have icons and are too much moved to right → "View/Hide Bookmarks Toolbar" and "View/Hide Bookmarks Sidebar" items are moved too much to right

Comment 6

a year ago
Pushed by paolo.mozmail@amadzone.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c4c41983362c
Fix class of the "View Bookmarks Toolbar" and "View Bookmarks Sidebar" items in the Bookmarks button menu. r=Gijs
(Assignee)

Comment 7

a year ago
Comment on attachment 8967945 [details]
Bug 1454148 - Fix class of the "View Bookmarks Toolbar" and "View Bookmarks Sidebar" items in the Bookmarks button menu.

This is part of the uplift request in bug 1391948 comment 17.
Attachment #8967945 - Flags: approval-mozilla-beta?
Comment on attachment 8967945 [details]
Bug 1454148 - Fix class of the "View Bookmarks Toolbar" and "View Bookmarks Sidebar" items in the Bookmarks button menu.

css fix for bookmarks menu, approved for 60.0b13
Attachment #8967945 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
https://hg.mozilla.org/mozilla-central/rev/c4c41983362c
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
I'm confirming that bug is fixed, starting in Mozilla Firefox Nightly 61.0a1 (2018-04-16), so I'm marking this bug as VERIFIED. Same as in latest Mozilla Firefox Beta. Thanks.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.