Form Autofill/History Assertion failure: mSearchesOngoing > 0 && mSearches.Contains(aSearch) in nsAutoCompleteController.cpp:821 - classify if failining test path contains "formautofill"
Categories
(Toolkit :: Form Autofill, enhancement, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox94 | --- | fixed |
People
(Reporter: intermittent-bug-filer, Assigned: dimi)
References
(Blocks 1 open bug)
Details
(Keywords: intermittent-failure, Whiteboard: [retriggered][stockwell unknown])
Attachments
(3 files)
Comment hidden (Intermittent Failures Robot) |
![]() |
||
Updated•7 years ago
|
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 6•6 years ago
|
||
Bug 1358643 is about a different autocomplete consumer so they aren't dupes.
dholbert hit this in a local debug build in a new profile with the following STR:
- Launch firefox with
--setpref signon.showAutoCompleteFooter=true --jsdebugger
- Visit https://wiki.mozilla.org/index.php?title=Special:UserLogin&returnto=Main+Page, couldn't get autocomplete dialog to appear, since this was a fresh profile and there was nothing to complete
- Type "abc" into the username field and hit 'enter' to submit
- Focused the username field on the login-failed-try-again page
Expected result:
No assertion failure
Actual result:
I saw a suggestion dropdown once or twice, and then got a content-process crash with that assertion failure (while clicking into & not-into that username field, IIRC)
Stack trace:
Assertion failure: mSearchesOngoing > 0 && mSearches.Contains(aSearch), at /scratch/work/builds/mozilla-inbound/mozilla/toolkit/components/autocomplete/nsAutoCompleteController.cpp:794
#01: nsAutoCompleteController::OnSearchResult(nsIAutoCompleteSearch*, nsIAutoCompleteResult*) (/scratch/work/builds/mozilla-inbound/mozilla/toolkit/components/autocomplete/nsAutoCompleteController.cpp:794)
#02: nsFormFillController::OnSearchCompletion(nsIAutoCompleteResult*) (/scratch/work/builds/mozilla-inbound/obj/toolkit/components/satchel/../../../../mozilla/toolkit/components/satchel/nsFormFillController.cpp:791)
#03: NS_InvokeByIndex (/scratch/work/builds/mozilla-inbound/obj/xpcom/reflect/xptcall/md/unix/../../../../../../mozilla/xpcom/reflect/xptcall/md/unix/xptcinvoke_asm_x86_64_unix.S:110)
Updated•6 years ago
|
Comment 7•6 years ago
|
||
I was only able to reproduce this once, BTW, so it seems to be a bit finicky.
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 11•6 years ago
|
||
Comment hidden (Intermittent Failures Robot) |
![]() |
||
Comment 13•6 years ago
|
||
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
![]() |
||
Updated•6 years ago
|
Comment 19•6 years ago
|
||
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 24•6 years ago
|
||
There are 92 total failures in the last 7 days on macosx1014-64 debug and windows7-32 debug.
Recent failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=258560085&repo=autoland&lineNumber=4282
[task 2019-07-26T20:58:36.292Z] 20:58:36 INFO - TEST-START | browser/extensions/formautofill/test/mochitest/test_basic_autocomplete_form.html
[task 2019-07-26T20:58:36.337Z] 20:58:36 INFO - [1741, Main Thread] WARNING: No active window: file /builds/worker/workspace/build/src/js/xpconnect/src/XPCJSContext.cpp, line 664
[task 2019-07-26T20:58:36.372Z] 20:58:36 INFO - GECKO(1744) | ++DOMWINDOW == 11 (0x1212e8800) [pid = 1746] [serial = 17] [outer = 0x11e7423e0]
[task 2019-07-26T20:58:36.408Z] 20:58:36 INFO - GECKO(1744) | [Child 1746, Main Thread] WARNING: NS_ENSURE_SUCCESS_VOID(rv) failed with result 0x80070057: file /builds/worker/workspace/build/src/toolkit/components/antitracking/AntiTrackingCommon.cpp, line 1857
[task 2019-07-26T20:58:36.430Z] 20:58:36 INFO - GECKO(1744) | [Child 1746, Main Thread] WARNING: NS_ENSURE_SUCCESS_VOID(rv) failed with result 0x80070057: file /builds/worker/workspace/build/src/toolkit/components/antitracking/AntiTrackingCommon.cpp, line 1857
[task 2019-07-26T20:58:36.430Z] 20:58:36 INFO - GECKO(1744) | [Parent 1744, Main Thread] WARNING: 'aRv.Failed()', file /builds/worker/workspace/build/src/dom/ipc/StructuredCloneData.cpp, line 120
[task 2019-07-26T20:58:36.498Z] 20:58:36 INFO - GECKO(1744) | --DOMWINDOW == 10 (0x11e7ecc00) [pid = 1746] [serial = 12] [outer = 0x0] [url = http://mochi.test:8888/tests/SimpleTest/iframe-between-tests.html]
[task 2019-07-26T20:58:36.498Z] 20:58:36 INFO - GECKO(1744) | --DOMWINDOW == 9 (0x11f4ed400) [pid = 1746] [serial = 11] [outer = 0x0] [url = http://mochi.test:8888/]
[task 2019-07-26T20:58:36.498Z] 20:58:36 INFO - GECKO(1744) | --DOMWINDOW == 8 (0x11f89ec00) [pid = 1746] [serial = 8] [outer = 0x0] [url = http://mochi.test:8888/tests/browser/extensions/formautofill/test/mochitest/test_address_level_1_submission.html]
[task 2019-07-26T20:58:36.968Z] 20:58:36 INFO - GECKO(1744) | [Parent 1744, Main Thread] WARNING: 'aRv.Failed()', file /builds/worker/workspace/build/src/dom/ipc/StructuredCloneData.cpp, line 120
[task 2019-07-26T20:58:36.968Z] 20:58:36 INFO - GECKO(1744) | [Parent 1744, Main Thread] WARNING: 'aRv.Failed()', file /builds/worker/workspace/build/src/dom/ipc/StructuredCloneData.cpp, line 120
[task 2019-07-26T20:58:36.968Z] 20:58:36 INFO - GECKO(1744) | [Parent 1744, Main Thread] WARNING: 'aRv.Failed()', file /builds/worker/workspace/build/src/dom/ipc/StructuredCloneData.cpp, line 120
[task 2019-07-26T20:58:41.254Z] 20:58:41 INFO - TEST-OK | browser/extensions/formautofill/test/mochitest/test_basic_autocomplete_form.html | took 4963ms
[task 2019-07-26T20:58:41.310Z] 20:58:41 INFO - GECKO(1744) | ++DOMWINDOW == 7 (0x11f89b800) [pid = 1746] [serial = 18] [outer = 0x11e7423e0]
[task 2019-07-26T20:58:41.313Z] 20:58:41 INFO - GECKO(1744) | Assertion failure: mSearchesOngoing > 0 && mSearches.Contains(aSearch), at /builds/worker/workspace/build/src/toolkit/components/autocomplete/nsAutoCompleteController.cpp:808
[task 2019-07-26T20:59:01.022Z] 20:59:01 INFO - GECKO(1744) | #01: non-virtual thunk to nsAutoCompleteController::OnSearchResult(nsIAutoCompleteSearch*, nsIAutoCompleteResult*) [toolkit/components/autocomplete/nsAutoCompleteController.cpp:0]
[task 2019-07-26T20:59:01.022Z] 20:59:01 INFO -
[task 2019-07-26T20:59:01.022Z] 20:59:01 INFO - GECKO(1744) | [Parent 1744, Main Thread] WARNING: IPC message discarded: actor cannot send: file /builds/worker/workspace/build/src/ipc/glue/ProtocolUtils.cpp, line 568
[task 2019-07-26T20:59:01.022Z] 20:59:01 INFO - GECKO(1744) | [Parent 1744, Main Thread] WARNING: IPC message discarded: actor cannot send: file /builds/worker/workspace/build/src/ipc/glue/ProtocolUtils.cpp, line 568
[task 2019-07-26T20:59:01.022Z] 20:59:01 INFO - GECKO(1744) | ++DOCSHELL 0x119024800 == 6 [pid = 1744] [id = {a52627dc-a11c-5d4d-acc9-efd4b7e258fa}]
[task 2019-07-26T20:59:01.022Z] 20:59:01 INFO - GECKO(1744) | ++DOMWINDOW == 11 (0x106d243e0) [pid = 1744] [serial = 12] [outer = 0x0]
[task 2019-07-26T20:59:01.022Z] 20:59:01 INFO - GECKO(1744) | ++DOMWINDOW == 12 (0x11a004800) [pid = 1744] [serial = 13] [outer = 0x106d243e0]
[task 2019-07-26T20:59:01.022Z] 20:59:01 ERROR - GECKO(1744) | A content process crashed and MOZ_CRASHREPORTER_SHUTDOWN is set, shutting down
[task 2019-07-26T20:59:01.023Z] 20:59:01 INFO - GECKO(1744) | ++DOMWINDOW == 13 (0x123b2d000) [pid = 1744] [serial = 14] [outer = 0x106d243e0]
[task 2019-07-26T20:59:01.023Z] 20:59:01 INFO - GECKO(1744) | [Child 1745, Main Thread] WARNING: nsAppShell::Exit() called redundantly: file /builds/worker/workspace/build/src/widget/cocoa/nsAppShell.mm, line 725
[task 2019-07-26T20:59:01.023Z] 20:59:01 INFO - GECKO(1744) | ###!!! [Parent][RunMessage] Error: Channel closing: too late to send/recv, messages will be lost
Matthew can you please assign someone? Failure rate is pretty high.
Comment hidden (Intermittent Failures Robot) |
Comment 26•6 years ago
|
||
Comment 27•6 years ago
|
||
Updated•6 years ago
|
Comment 28•6 years ago
|
||
bugherder |
Comment hidden (Intermittent Failures Robot) |
Updated•6 years ago
|
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
![]() |
||
Updated•5 years ago
|
Comment hidden (Intermittent Failures Robot) |
Comment 57•4 years ago
|
||
Timothy, could the recent spike in failures be caused by the changes in Bug 1728697?:
https://treeherder.mozilla.org/jobs?repo=autoland&searchStr=Android%2C7.0%2Cx86-64%2CWebRender%2Cdebug%2Ctest-android-em-7.0-x86_64-qr%2Fdebug-geckoview-junit-e10s%2Cgv-junit&tochange=52cb6fbb1075162e2bda1d9caa1e04b5023acdc4&fromchange=7c99e54438e71f59aa2b1e1d49d7db1fc603a980&selectedTaskRun=CNq6DRRmTLmwgz1rJa-7Cg.0
Comment 58•4 years ago
|
||
Probably not, my change would only have an effect with fission and fission is not activated in those tests. I did some retriggers and there is a push in that link now that touches android code that has failures of this type but no previous push does.
Comment 59•4 years ago
|
||
Hi Agi, could you take a look? I think this is from bug 1676216.
Updated•4 years ago
|
Comment hidden (Intermittent Failures Robot) |
Comment 61•4 years ago
•
|
||
Dimi, is this something that someone in your team can take a look at? I'm not sure what is happening here. I added more logging in this try run: https://treeherder.mozilla.org/jobs?repo=try&revision=2b0f74a0e6849815535e52ef095900f34831a27f&selectedTaskRun=BXboOJEUQ6GREcsNegunPA.0 and from what I can tell the code that is throwin the assertion doesn't run at all for successful test runs, but I'm not sure why. E.g. this is the log for a successful test run: https://paste.mozilla.org/24KKSsg8 (you can see there's no sferrog:
logs in there).
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 63•4 years ago
|
||
(In reply to Agi Sferro | :agi | ni? for questions | ⏰ PST | he/him from comment #61)
Dimi, is this something that someone in your team can take a look at? I'm not sure what is happening here. I added more logging in this try run:
Sure, I'll take a look at this one.
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 67•4 years ago
|
||
While calling StopSearch(), we only stop either seaches triggered by
formautofill or the password manager, but not both. So when there are both an ongoing
formautofill search and login manager search, the search from the login
manager is not canceled, which messes up the internal state of nsFormFillController.
Assignee | ||
Updated•4 years ago
|
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Updated•4 years ago
|
Comment 69•4 years ago
|
||
Comment 70•4 years ago
|
||
bugherder |
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 72•4 years ago
|
||
Looks like this bug is fixed! I'll close the bug!
Updated•4 years ago
|
Comment 73•4 years ago
|
||
Dimi: should we re-enable test_basic_autocomplete_form.html? It was disabled a while back, comment 27.
Assignee | ||
Comment 74•4 years ago
|
||
(In reply to Andreea Pavel [:apavel] from comment #73)
Dimi: should we re-enable test_basic_autocomplete_form.html? It was disabled a while back, comment 27.
I'm not 100% sure if my patch also fixes the issue on those platforms, but yes, let's re-enable the test and see what will happen.
Assignee | ||
Comment 75•4 years ago
|
||
Comment 76•4 years ago
|
||
Comment 77•4 years ago
|
||
bugherder |
Updated•4 years ago
|
Comment hidden (Intermittent Failures Robot) |
Description
•