1454225 - Add icons to "View/Hide Bookmarks Toolbar" and "View/Hide Bookmarks Sidebar" items

Status: NEW

(Firefox :: Theme, enhancement, P5)

Comment 1

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: is.png

It was first and main aim of bug #1391948, which was morphed.

Comment 2

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: should be.png

P.S. These are old screenshots.

Comment 3

[Dão Gottwald [:dao]]

Traditionally the history and bookmark menus only ever displayed icons for history and bookmark items. Setting an icon for the other items can easily feel overloaded and I'm not sure it provides significant user value.

Comment 4

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Seeing corresponding icon to its item is faster than reading text.
What's more, same thing was done for hamburger menu, so it's also for consistency.

Comment 5

[Dão Gottwald [:dao]]

(In reply to Virtual_ManPL [:Virtual] - (please needinfo? me - so I will see your comment/reply/question/etc.) from comment #4)
> Seeing corresponding icon to its item is faster than reading text.

There's muscle memory too. People who use these items regularly will remember their location, and people who use the menu primarily to access bookmarks might not appreciate the visual noise from the additional icons.