1454260 - storage.sync does not actually sync data

Status: RESOLVED WORKSFORME

(WebExtensions :: Storage, defect)

Description

[ramkumar.kr94]

Attachment: favourite_colour-1.1-an+fx-windows.xpi

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0
Build ID: 20180404120016

Steps to reproduce:

Using https://github.com/mdn/webextensions-examples/tree/master/favourite-colour as an example addon here

Please find a signed version of the addon Attached 

1. Create a firefox sync account and have two installations of firefox synced to the account
2. Get it signed by mozilla addon store (change the addon id so that it can remain unique across the addon store)
3. Install the addon in both installations of firefox
4. Set favorite color in the addon preferences page (which uses storage.sync to store and retrieve data)
5. Click on sync in both installations

The installations used are Firefox 59 (64-bit) on Ubuntu and Firefox 60  Developer edition (64-bit) on Ubuntu


Actual results:

Favorite color was different in both installations of firefox even after using firefox sync


Expected results:

Favourite color should have synced between the two installations of firefox

Comment 1

[Kanchan Kumari QA]

Hello Ram, did you make sure in about:preferences?entrypoint=menupanel#sync Add-ons option is checked? If it's not checked it will not sync addons preferences.

Comment 2

[ramkumar.kr94]

Hi,

All options except logins in the sync settings are checked in both the devices.

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

Hi ramkumar.kr94,
Are you still able to trigger the sync issue on a recent Nightly?
if you can still reproduce the issue on a clean profile, do you mind to collect any Firefox Sync log file that may have been created (especially errors log files, if any) and attach them to this issue? (the Firefox Sync log files are available from from "about:sync-log")  

Currently I'm been unable to reproduce this issue locally:
I've installed the attached extension on a recent Nightly (64.0a1) running on two different machines (one with Linux, the second one with MacOS) and then I signed in on Firefox Accounts from both the instances and tried to change the extension value stored from one instance (and pressed the sync button) and then sync it from the other one.
I've also tried to run the sync from both sides (just to double-check that both the instances were able to both read and write their data from sync).

The extension data has been always correctly stored and synced between the two instances, only the first time that I tried to run sync there has been a "sync error log file" collected and available from "about:sync-log" ([1]), but it has been a transient issue which only happened once and then the sync didn't ever fail again.

[1]: at "about:sync-log" there are the Firefox Sync logs, the following is the only transient sync error that I've been able to trigger once locally:

1540219233144    Sync.Engine.Extension-Storage    ERROR    Syncing [e-mail]: request failed: TypeError: NetworkError when attempting to fetch resource. No traceback available
1540219233144    Sync.Engine.Extension-Storage    WARN    Syncing failed: TypeError: NetworkError when attempting to fetch resource. No traceback available
1540219233144    Sync.Status    DEBUG    Status for engine extension-storage: error.engine.reason.unknown_fail
1540219233144    Sync.Status    DEBUG    Status.service: success.status_ok => error.sync.failed_partial
1540219233144    Sync.ErrorHandler    DEBUG    extension-storage failed: TypeError: NetworkError when attempting to fetch resource. No traceback available
1540219233144    Sync.Doctor    INFO    Skipping check of addons - disabled via preferences
1540219233144    Sync.Doctor    INFO    Skipping check of extension-storage - disabled via preferences
1540219233144    Sync.Doctor    INFO    Skipping validation: no engines qualify
1540219233145    Sync.Synchronizer    INFO    Sync completed at 2018-10-22 16:40:33 after 1.85 secs.
1540219233145    Sync.Declined    DEBUG    Handling remote declined: ["tabs","bookmarks","passwords","history","prefs","addresses","creditcards"]
1540219233146    Sync.Declined    DEBUG    Handling local declined: ["tabs","bookmarks","passwords","history","prefs","addresses","creditcards"]
1540219233146    Sync.Declined    DEBUG    Declined changed? false
1540219233146    Sync.Service    INFO    No change to declined engines. Not reuploading meta/global.
1540219233146    Sync.ErrorHandler    ERROR    Some engines did not sync correctly.
1540219233147    Sync.SyncScheduler    DEBUG    Next sync in 3600000 ms. (why=schedule)

Comment 4

[Luca Greco [:rpl] [:luca] [:lgreco]]

Closing, as we were unable to reproduce the issue reported (and it worked as expected when I tried locally to collect some additional information from the Sync logs).

Feel free to re-open if you are still able to reproduce the issue and you have been able to collect the related Sync logs.