Remove CSS_PROP_LOGICAL and corresponding macros

RESOLVED FIXED in Firefox 61

Status

()

enhancement
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: xidorn, Assigned: xidorn)

Tracking

Trunk
mozilla61
Points:
---

Firefox Tracking Flags

(firefox61 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
It seems almost every define of CSS_PROP comes with CSS_PROP_LIST_INCLUDE_LOGICAL, and no one uses CSS_PROP_LIST_EXCLUDE_LOGICAL.

The only place where CSS_PROP_LOGICAL is used is PythonCSSProps.h. It generates "logical" as prototype for logical properties, but it doesn't seem to me anything really cares about this specific prototype.

So we should be able to remove all the CSS_PROP_LOGICAL-related stuff.
(Assignee)

Comment 1

a year ago
(In reply to Xidorn Quan [:xidorn] UTC+10 from comment #0)
> The only place where CSS_PROP_LOGICAL is used is PythonCSSProps.h. It
> generates "logical" as prototype for logical properties, but it doesn't seem
> to me anything really cares about this specific prototype.

s/prototype/proptype/g
Comment hidden (mozreview-request)

Comment 3

a year ago
mozreview-review
Comment on attachment 8968110 [details]
Bug 1454297 - Remove CSS_PROP_LOGICAL and friends.

https://reviewboard.mozilla.org/r/236788/#review242528

Looks good, thank you!
Attachment #8968110 - Flags: review?(emilio) → review+

Comment 4

a year ago
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7d35e0be4b57
Remove CSS_PROP_LOGICAL and friends. r=emilio
https://hg.mozilla.org/mozilla-central/rev/7d35e0be4b57
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.