Closed Bug 1454297 Opened 2 years ago Closed 2 years ago

Remove CSS_PROP_LOGICAL and corresponding macros

Categories

(Core :: CSS Parsing and Computation, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

References

Details

Attachments

(1 file)

It seems almost every define of CSS_PROP comes with CSS_PROP_LIST_INCLUDE_LOGICAL, and no one uses CSS_PROP_LIST_EXCLUDE_LOGICAL.

The only place where CSS_PROP_LOGICAL is used is PythonCSSProps.h. It generates "logical" as prototype for logical properties, but it doesn't seem to me anything really cares about this specific prototype.

So we should be able to remove all the CSS_PROP_LOGICAL-related stuff.
(In reply to Xidorn Quan [:xidorn] UTC+10 from comment #0)
> The only place where CSS_PROP_LOGICAL is used is PythonCSSProps.h. It
> generates "logical" as prototype for logical properties, but it doesn't seem
> to me anything really cares about this specific prototype.

s/prototype/proptype/g
Comment on attachment 8968110 [details]
Bug 1454297 - Remove CSS_PROP_LOGICAL and friends.

https://reviewboard.mozilla.org/r/236788/#review242528

Looks good, thank you!
Attachment #8968110 - Flags: review?(emilio) → review+
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7d35e0be4b57
Remove CSS_PROP_LOGICAL and friends. r=emilio
https://hg.mozilla.org/mozilla-central/rev/7d35e0be4b57
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.