Closed
Bug 1454298
Opened 6 years ago
Closed 6 years ago
Add UTM parameters to new devtools menu links
Categories
(DevTools :: General, enhancement)
DevTools
General
Tracking
(firefox61 verified)
VERIFIED
FIXED
Firefox 61
Tracking | Status | |
---|---|---|
firefox61 | --- | verified |
People
(Reporter: Harald, Assigned: birtles)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
Without them we don't know if users click through. UTM parameters should follow what Console is already adding for MDN links for error messages.
Assignee | ||
Comment 1•6 years ago
|
||
Looking through devtools code I see: devtools/client/netmonitor/src/utils/mdn-utils.js - utm_source=mozilla&utm_medium=devtools-${panelId}&utm_campaign=default devtools/client/preferences/devtools-client.js - https://www.mozilla.org/firefox/developer/?utm_source=firefox-dev-tools&utm_medium=firefox-browser&utm_content=betadoorhanger devtools/server/actors/errordocs.js - ?utm_source=mozilla&utm_medium=firefox-console-errors&utm_campaign=default devtools/startup/aboutdevtools/aboutdevtools.js - ?utm_source=devtools&utm_medium=onboarding I'm guessing we want: utm_source = mozilla utm_medium = devtools-menu (devtools-meatball-menu?) utm_campaign = default (necessary?) ? Alternatively, elsewhere in the tree I see utm_source=firefox / firefox-browser / inproduct used quite often. Harald, any suggestions here?
Flags: needinfo?(hkirschner)
Assignee | ||
Updated•6 years ago
|
Version: 57 Branch → Trunk
Reporter | ||
Comment 2•6 years ago
|
||
Thank you for the research, Brian! Let's go with the latest addition, which also seems to most sensible. utm_source = devtools utm_medium = tabbar-menu No campaign.
Flags: needinfo?(hkirschner)
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → bbirtles
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment 6•6 years ago
|
||
mozreview-review |
Comment on attachment 8970763 [details] Bug 1454298 - Add utm_source and utm_medium parameters to DevTools menu links; https://reviewboard.mozilla.org/r/239522/#review245440
Attachment #8970763 -
Flags: review?(jryans) → review+
Pushed by bbirtles@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0b8f0217bda4 Add utm_source and utm_medium parameters to DevTools menu links; r=jryans
Comment hidden (mozreview-request) |
Updated•6 years ago
|
Attachment #8971088 -
Attachment is obsolete: true
Attachment #8971088 -
Flags: review?(jryans)
Comment 9•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0b8f0217bda4
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Comment 10•6 years ago
|
||
I have reproduced this issue using Firefox 61.0a1 (2018.04.15) on Ubuntu 14.04 x64. I can confirm this issue is fixed, I verified using Firefox 61.0b10 on Win 10 x64, Ubuntu 14.04 x64 and Mac OS X 10.13. Note: I met the following behavior: 1. When I click on Meatball/Documentation menu link in URL appears for a few seconds the: utm_source = devtools utm_medium = tabbar-menu
Comment 11•6 years ago
|
||
I have reproduced this issue using Firefox 61.0a1 (2018.04.15) on Ubuntu 14.04 x64. I can confirm this issue is fixed, I verified using Firefox 61.0b10 on Win 10 x64, Ubuntu 14.04 x64 and Mac OS X 10.13. Note: I met the following behavior: 1. When I click on Meatball/Documentation menu item, in URL appears for a few seconds the: utm_source = devtools and utm_medium = tabbar-menu but after the page was loaded the url became: https://developer.mozilla.org/en-US/docs/Tools 2. Click on Meatball/Community menu item, after the page was loaded the url is: https://discourse.mozilla.org/c/devtools?utm_source=devtools&utm_medium=tabbar-menu This is the expected behavior?
Flags: needinfo?(bbirtles)
Assignee | ||
Comment 12•6 years ago
|
||
I guess you're getting some sort of redirect that drops the utm parameters. If they show initially then this is working as expected.
Flags: needinfo?(bbirtles)
Comment 13•6 years ago
|
||
Based on comment 12 I'll mark this as verified as fixed on Firefox 61.0b11 on Windows 10 x64, Mac OS X 10.13 and Ubuntu 14.04 x64.
Status: RESOLVED → VERIFIED
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•