Closed Bug 1454299 Opened 2 years ago Closed 2 years ago

Remove ServoPropPrefList.h

Categories

(Core :: CSS Parsing and Computation, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

Details

Attachments

(1 file)

It doesn't seem to me it is used anymore.
Comment on attachment 8968113 [details]
Bug 1454299 - Remove ServoPropPrefList.h.

https://reviewboard.mozilla.org/r/236792/#review242530

Looks like I replaced its use for something simpler in https://github.com/servo/servo/pull/19235, and I never realized we could remove this. Oh well!

::: layout/style/ServoBindings.toml:53
(Diff revision 1)
>  [structs]
>  headers = [
>      "nsStyleStruct.h",
> -    "mozilla/ServoPropPrefList.h",
>      "mozilla/StyleAnimationValue.h",
>      "gfxFontConstants.h",

You should also remove the `mozilla::SERVO_PREF_.*` whitelist entry below this block.
Attachment #8968113 - Flags: review?(emilio) → review+
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ed99d7ab90b9
Remove ServoPropPrefList.h. r=emilio
https://hg.mozilla.org/mozilla-central/rev/ed99d7ab90b9
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Assignee: nobody → xidorn+moz
You need to log in before you can comment on or make changes to this bug.