1454303 - Firefox Nightly on Android fails to save home screen shortcuts on Oreo without any error when the launcher doesn't support the new shortcut API

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect, P5)

Description

[Dave Miller [:justdave]]

Sounds like it may be a dupe of bug 1372926 except that was supposedly fixed 7 months ago, and this is broken now.

Steps to reproduce:

1) Go to any web page in Firefox
2) tap on expansion menu (︙)
3) Go to Page >
4) Notice that "Add Page Shortcut" is grayed out.
5) tap and hold on URL bar
6) tap "Add Page Shortcut" from that popup menu.
7) nothing happens.

"Firefox Nightly" 61.0a1

Samsung Galaxy S8, unlocked.  Samsung just updated it to Oreo from Nougat this last week.

Comment 1

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

works for me (i added instagram.com/roland) Android 8 aka Oreo, Samsung Galazy Note 8 aka SM-950W, Nightly Firefox for Android 61 from April 16, 2018. is it just some Note 8s and some S8s? (usually broken Sx means broken Note x in my experience)

Comment 2

[Dave Miller [:justdave]]

This is still broken for me on nightly.

I've had a few software updates from Samsung since this was filed (mostly just pushing security updates).
Still Android 8.0.0 (Oreo) with Android security patch May 1 2018.

Maybe something special about Galaxy S8 that's different from the Note?

I just hooked up my USB debugging, and when I do the tap+hold on the URL bar and pick Add Page Shortcut from there, I get the following in the log:

W | 05-31 21:30:16.798 |  3568 | system_server                                 | ShortcutService           | Launcher doesn't support requestPinnedShortcut(). Shortcut not created.

Comment 3

[Dave Miller [:justdave]]

I'm using the Apex Launcher...  I switched back to "Samsung Experience" and now it works.  It always used to work in Apex, so I'm guessing they changed the API in 8.0 and Firefox knows about it, and Apex doesn't support the new API yet?

Comment 4

[Dave Miller [:justdave]]

Yep, confirmed, Apex doesn't implement the new shortcut API yet.
https://apexlauncher.uservoice.com/forums/146396-apex-general-feedback/suggestions/32729107-update-to-full-oreo-android-8-support

Suggested action for this bug:  uplift the error message when it fails, so the user has a clue why it doesn't work.  I had to pull a USB debug log in order to find the error.  That's bad UX.

Comment 5

[Dave Miller [:justdave]]

Apex released a new version today which fixes this issue.

I still suggest fixing the error reporting when this is encountered in case any other launcher has this issue.

Comment 6

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 7

[Diana Rus]

Hi,

I managed to reproduce the issue.

Environment
Device: Google Pixel C, Android (8.0.0)
Build: Firefox Beta 67.0b15

As a side note, it has also been tested on Nexus 9(Android 7.1.1) but could not be reproduced.

Regards,
Diana Rus

Comment 8

[Diana Rus]

Hi, I reproduced the issue with device Google Pixel C (Android 8.0.0) on Firefox Nightly 69.0a1(2019-07-04).

Comment 10

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.