Closed Bug 1454314 Opened 2 years ago Closed 2 years ago

Fix devtools notification emails in Scalars.yaml

Categories

(DevTools :: General, enhancement, P3)

enhancement

Tracking

(firefox61 fixed)

RESOLVED FIXED
Firefox 61
Tracking Status
firefox61 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

Details

Attachments

(1 file)

We have several errors in notification emails for devtools scalars in Scalars.yaml:

See Bug 1447302 Comment 10

(In reply to Chris H-C :chutten from comment #10)
> Comment on attachment 8966348 [details] [diff] [review]
> 1447302 patch v2
> 
> Review of attachment 8966348 [details] [diff] [review]:
> 
> [1]:
> https://searchfox.org/mozilla-central/rev/
> 4114ad2cfcbc511705c7865a4a34741812f9a2a9/security/sandbox/win/src/
> sandboxbroker/sandboxBroker.cpp#333
> [2]:
> https://searchfox.org/mozilla-central/rev/
> 4114ad2cfcbc511705c7865a4a34741812f9a2a9/services/sync/modules/
> browserid_identity.js#96,116
> 
> ::: toolkit/components/telemetry/Scalars.yaml
> @@ +991,5 @@
> > +      Accessibility tool (navgiation to Accessibility panel).
> > +    expires: never
> > +    kind: uint
> > +    notification_emails:
> > +      - dev-developer-tools@lists.mozilla.org, yzenevich@mozilla.com
> 
> This isn't how multiple entries are done in a yaml list, see
> browser.session.restore.worker_restart_count for an example.
> 

See https://searchfox.org/mozilla-central/search?q=%5C%40%5B%5E%2C%5D%2B%2C&case=true&regexp=true&path=Scalars
Severity: normal → enhancement
Priority: -- → P3
Comment on attachment 8968460 [details]
Bug 1454314 - fix notification email lists in Scalars.yaml;

https://reviewboard.mozilla.org/r/237168/#review243126

Excellent, thank you for this. I'll go file a bug to see if we can perform some validation at parse time to help catch these sooner.
Attachment #8968460 - Flags: review?(chutten) → review+
See Also: → 1454737
(In reply to Chris H-C :chutten from comment #2)
> Comment on attachment 8968460 [details]
> Bug 1454314 - fix notification email lists in Scalars.yaml;
> 
> https://reviewboard.mozilla.org/r/237168/#review243126
> 
> Excellent, thank you for this. I'll go file a bug to see if we can perform
> some validation at parse time to help catch these sooner.

Thanks for the review, validating would be great!

On the topic of devtools/telemetry, we will open a RFC on our side to review DevTools' telemetry helper.
Since we ask for review and advice from you and other data-peers, it really makes sense to stick to APIs that can be easily understood outside of DevTools.
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/32badf66ccff
fix notification email lists in Scalars.yaml;r=chutten
https://hg.mozilla.org/mozilla-central/rev/32badf66ccff
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.