Closed Bug 1454314 Opened 2 years ago Closed 2 years ago
Fix devtools notification emails in Scalars
59 bytes, text/x-review-board-request
We have several errors in notification emails for devtools scalars in Scalars.yaml: See Bug 1447302 Comment 10 (In reply to Chris H-C :chutten from comment #10) > Comment on attachment 8966348 [details] [diff] [review] > 1447302 patch v2 > > Review of attachment 8966348 [details] [diff] [review]: > > : > https://searchfox.org/mozilla-central/rev/ > 4114ad2cfcbc511705c7865a4a34741812f9a2a9/security/sandbox/win/src/ > sandboxbroker/sandboxBroker.cpp#333 > : > https://searchfox.org/mozilla-central/rev/ > 4114ad2cfcbc511705c7865a4a34741812f9a2a9/services/sync/modules/ > browserid_identity.js#96,116 > > ::: toolkit/components/telemetry/Scalars.yaml > @@ +991,5 @@ > > + Accessibility tool (navgiation to Accessibility panel). > > + expires: never > > + kind: uint > > + notification_emails: > > + - firstname.lastname@example.org, email@example.com > > This isn't how multiple entries are done in a yaml list, see > browser.session.restore.worker_restart_count for an example. > See https://searchfox.org/mozilla-central/search?q=%5C%40%5B%5E%2C%5D%2B%2C&case=true®exp=true&path=Scalars
Severity: normal → enhancement
Priority: -- → P3
Comment on attachment 8968460 [details] Bug 1454314 - fix notification email lists in Scalars.yaml; https://reviewboard.mozilla.org/r/237168/#review243126 Excellent, thank you for this. I'll go file a bug to see if we can perform some validation at parse time to help catch these sooner.
Attachment #8968460 - Flags: review?(chutten) → review+
(In reply to Chris H-C :chutten from comment #2) > Comment on attachment 8968460 [details] > Bug 1454314 - fix notification email lists in Scalars.yaml; > > https://reviewboard.mozilla.org/r/237168/#review243126 > > Excellent, thank you for this. I'll go file a bug to see if we can perform > some validation at parse time to help catch these sooner. Thanks for the review, validating would be great! On the topic of devtools/telemetry, we will open a RFC on our side to review DevTools' telemetry helper. Since we ask for review and advice from you and other data-peers, it really makes sense to stick to APIs that can be easily understood outside of DevTools.
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/32badf66ccff fix notification email lists in Scalars.yaml;r=chutten
You need to log in before you can comment on or make changes to this bug.