1454317 - Shape Path Editor icon shows wrong state when editing CSS property

Status: VERIFIED FIXED

(DevTools :: Inspector, defect, P3)

Description

[Martin Balfanz [:mbalfanz]]

Attachment: icon-state.mp4

The shape path editor icon in the rules panel shows then wrong state after editing the CSS property directly.

STR:
1. Open the inspector and inspect an element with shape-outside applied
2. Activate the shape path editor by clicking on the icon. The icon will be blue
3. Click the CSS property in order to edit it
4. Unfocus the input field again

Expected result:
- The shape path editor and it's icon will still be activated

Actual result
- The shape path editor is still activated, but the icon shows a deactivated state

Comment 2

[Timea Cernea [:tbabos][inactive]]

Please note that by following the steps from Comment 0 the highlights in the rule-view will also not work. Fore reference, please check the attached file.

Comment 3

[Timea Cernea [:tbabos][inactive]]

Attachment: GIF. of the issue(rule-view highlights)

Comment 4

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1454317 - Reference correct shape swatch element after editing value in rule view.

Review commit: https://reviewboard.mozilla.org/r/251484/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/251484/

Comment 5

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8986006 [details]
Bug 1454317 - Reference correct shape swatch element after editing value in rule view.

https://reviewboard.mozilla.org/r/251484/#review257742

::: devtools/client/shared/widgets/ShapesInContextEditor.js:249
(Diff revision 1)
>    }
>  
>    /**
> +  * Handler for "property-value-updated" event triggered by the Rule view.
> +  * Called after the shape value has been written to the element's style and the Rule
> +  * view updated. Triggers an event on HighlightersOverlay that is expected by

s/Triggers/Emits

Comment 6

[Razvan Caliman [:rcaliman]]

Comment on attachment 8986006 [details]
Bug 1454317 - Reference correct shape swatch element after editing value in rule view.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/251484/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c4f5978d9da
Reference correct shape swatch element after editing value in rule view. r=gl

Comment 8

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/7c4f5978d9da

Comment 9

[Rares Doghi, Desktop QA]

Hi guys , i retested this issue and it no longer occurs in version 62.0a1 (2018-06-19). I will Mark it Verified as Fixed.