Closed
Bug 1454338
Opened 6 years ago
Closed 6 years ago
[mozversion] Remove support for B2G
Categories
(Testing :: Mozbase, enhancement)
Tracking
(firefox61 fixed)
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: davehunt, Assigned: davehunt)
Details
Attachments
(1 file)
Whilst looking at the source code for mozversion I noticed there's still quite a lot of B2G related code.
Comment hidden (mozreview-request) |
Comment 2•6 years ago
|
||
mozreview-review |
Comment on attachment 8968158 [details] Bug 1454338 - [mozversion] Remove support for B2G; https://reviewboard.mozilla.org/r/236834/#review242584 Thanks for the cleanup! ::: testing/mozbase/docs/mozversion.rst (Diff revision 1) > `mozversion <https://github.com/mozilla/mozbase/tree/master/mozversion>`_ > provides version information such as the application name and the changesets > that it has been built from. This is commonly used in reporting or for > conditional logic based on the application under test. > > -Note that mozversion can report the version of remote devices (e.g. Firefox OS) Hah, looks like we weren't even using `mozdevice` for b2g! ::: testing/mozbase/mozversion/setup.py:9 (Diff revision 1) > > from __future__ import absolute_import > > from setuptools import setup > > PACKAGE_VERSION = '1.5' Since this is technically a backwards incompatible change (even though I know no one is depending on this code anymore), we might as well make the switch to SemVer here. Please bump to 2.0.0 ::: testing/mozbase/mozversion/setup.py:26 (Diff revision 1) > url='https://wiki.mozilla.org/Auto-tools/Projects/Mozbase', > license='MPL', > packages=['mozversion'], > include_package_data=True, > zip_safe=False, > - install_requires=['mozfile >= 1.0', > + install_requires=['mozlog >= 3.0', Please add an upper version limit here: mozlog>=3,<4
Attachment #8968158 -
Flags: review?(ahalberstadt) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Comment 4•6 years ago
|
||
mozreview-review-reply |
Comment on attachment 8968158 [details] Bug 1454338 - [mozversion] Remove support for B2G; https://reviewboard.mozilla.org/r/236834/#review242584 > Hah, looks like we weren't even using `mozdevice` for b2g! We were until https://bugzilla.mozilla.org/show_bug.cgi?id=1440714 > Please add an upper version limit here: > > mozlog>=3,<4 I used a compatible release version indicator https://www.python.org/dev/peps/pep-0440/#compatible-release
Comment 5•6 years ago
|
||
mozreview-review-reply |
Comment on attachment 8968158 [details] Bug 1454338 - [mozversion] Remove support for B2G; https://reviewboard.mozilla.org/r/236834/#review242584 > I used a compatible release version indicator https://www.python.org/dev/peps/pep-0440/#compatible-release Maybe can we do the release in its own commit? It would help a lot when checking the pushlog later.
Pushed by dhunt@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/057c58bcb1b1 [mozversion] Remove support for B2G; r=ahal
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/057c58bcb1b1
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•