Closed Bug 1454340 Opened 2 years ago Closed 2 years ago

Get rid of SetAsUndisplayedContent.

Categories

(Core :: Layout, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: emilio, Assigned: emilio)

Details

Attachments

(1 file)

No description provided.
Comment on attachment 8968151 [details]
Bug 1454340: Get rid of SetAsUndisplayedContent.

https://reviewboard.mozilla.org/r/236824/#review242690

LGTM, thanks for preserving the assertion.

::: layout/base/nsCSSFrameConstructor.cpp
(Diff revision 1)
> -    if (!isText) {
> -      SetAsUndisplayedContent(aState, aItems, aContent, computedStyle,

I'm assuming this check is unnecessary.

nit: Could you move the declaration of isText down to where it's used next please.
Attachment #8968151 - Flags: review?(mats) → review+
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e9f29bf619f3
Get rid of SetAsUndisplayedContent. r=mats
https://hg.mozilla.org/mozilla-central/rev/e9f29bf619f3
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.