Closed
Bug 1454348
Opened 6 years ago
Closed 3 years ago
Can we remove RequiredDefines.h yet?
Categories
(Core :: JavaScript Engine, enhancement, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
DUPLICATE
of bug 1708330
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | affected |
People
(Reporter: anba, Unassigned)
Details
Sources like <https://sourceware.org/bugzilla/show_bug.cgi?id=15366> and <https://cplusplus.github.io/LWG/issue593> seem to suggest it's no longer necessary to define __STDC_LIMIT_MACROS et al.
RequiredDefines.h's #include for "mozilla/Char16.h" is probably also no longer necessary.
|
||
Updated•6 years ago
|
Priority: -- → P3
|
Reporter | |
Comment 1•6 years ago
|
||
Simply removing it doesn't seem to work -> <https://treeherder.mozilla.org/#/jobs?repo=try&revision=4834047121ccf12b09347663621dc699da0062eb>.
Interestingly the patch works locally for me on Ubuntu 17.10 (gcc 7.2), maybe the libc version on the CI servers is too old and doesn't yet ignore __STDC_LIMIT_MACROS (which should happen for newer libc as per comment #0).
|
|
Reporter | |
Updated•3 years ago
|
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•