Closed Bug 1454465 Opened Last year Closed Last year

Turn override prefs that are on by default back into regular prefs

Categories

(Core :: Graphics: WebRender, enhancement, P2)

Other Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: kats, Assigned: kats)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

Right now when we run automated tests for QR we run them with MOZ_ACCELERATED=1 and MOZ_WEBRENDER=1. This basically sets gfx.webrender.enabled=true, but really we want to be testing with gfx.webrender.all=true which is what we're asking people to run locally.
Hm. I thought that gfx.webrender.all was enabling other prefs but that turns out to be the case. The only two prefs that are currently marked as "override prefs" dependent on gfx.webrender.all are image.mem.shared and gfx.webrender.blob-images, and both of those are set to "1" in all.js. Which means they are going to be enabled regardless of whether gfx.webrender.all is true or false. So we might as well turn them back into regular prefs.

It also means that what's running in automation is the same as what happens when gfx.webrender.all is enabled by a user, because in both cases WR is enabled, and the image.mem.shared and gfx.webrender.blob-images prefs are already set to true.
Summary: Run gecko automation with gfx.webrender.all=true → Turn override prefs that are on by default back into regular prefs
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #1)
> Hm. I thought that gfx.webrender.all was enabling other prefs but that turns
> out to be the case.

I meant to say ".. that turns out NOT to be the case."
Assignee: nobody → bugmail
Comment on attachment 8969056 [details]
Bug 1454465 - Turn some override prefs back into regular prefs.

https://reviewboard.mozilla.org/r/237744/#review243516
Attachment #8969056 - Flags: review?(jmuizelaar) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8fa230eb9ec7
Turn some override prefs back into regular prefs. r=jrmuizel
https://hg.mozilla.org/mozilla-central/rev/8fa230eb9ec7
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.