Closed
Bug 1454469
Opened 6 years ago
Closed 6 years ago
wpts using event.srcElement will fail when Gecko 61 merges to Beta on 2018-04-26
Categories
(Core :: DOM: Core & HTML, defect, P1)
Core
DOM: Core & HTML
Tracking
()
VERIFIED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox59 | --- | unaffected |
firefox60 | --- | unaffected |
firefox61 | + | verified |
People
(Reporter: aryx, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
Those tests got added in bug 1450367 (dev Mike Taylor CC-ed). central-as-beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9206bffc4b2f66ff8f840579eab262ba6cf39f3c&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable&filter-resultStatus=pending&filter-resultStatus=running&group_state=expanded&selectedJob=173874594 Those are all tests related to events. Investigated the first one and it fails because it uses event.srcElement which is only enabled on Nightly: https://dxr.mozilla.org/mozilla-central/source/dom/events/Event.cpp?q=issrcelementenabled&redirect_type=direct#250-259 Because this is not controlled by a pref, the tests can't be fixed by toggling one. bz, what should be done here? Thank you in advance.
Flags: needinfo?(bzbarsky)
Updated•6 years ago
|
Comment 1•6 years ago
|
||
Is there a way to make the tests nightly-only like we're doing with event.srcElement?
Flags: needinfo?(aryx.bugmail)
Assignee | ||
Comment 2•6 years ago
|
||
> bz, what should be done here?
An .ini that claims the tests fail on non-nightly would be ideal here. James, is there an annotation for that? I'm not seeing existing ones like that...
Failing that we could land an .ini on beta channel claiming the test fails and keep doing that every merge.
We could _try_ to make this pref-controlled, but it's exposed in workers so it's a huge pain to do that.
Flags: needinfo?(bzbarsky) → needinfo?(james)
Reporter | ||
Updated•6 years ago
|
Flags: needinfo?(aryx.bugmail)
Comment 3•6 years ago
|
||
So everything in mozinfo.json should be avaiable for setting metadata. In this case release_or_beta might work i.e. expected: if release_or_beta: FAIL
Flags: needinfo?(james)
Assignee | ||
Comment 4•6 years ago
|
||
Fixes things for me in a local build with those beta-simulation patches applied
Attachment #8968623 -
Flags: review?(aryx.bugmail)
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Reporter | ||
Updated•6 years ago
|
Attachment #8968623 -
Flags: review?(aryx.bugmail) → review+
Updated•6 years ago
|
Priority: -- → P1
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e3509035413c Annotate web platform tests involving event.srcElement as failing on beta and release. r=aryx
Comment 6•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e3509035413c
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Reporter | ||
Comment 7•6 years ago
|
||
Verified fixed with the latest central-as-beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3eb7c05a2a4cfd295545d947ddc581279beb92dd&group_state=expanded&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=usercancel&filter-resultStatus=runnable
Status: RESOLVED → VERIFIED
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•