1454503 - Remove unused RestyleManager refcounting.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Emilio Cobos Álvarez [:emilio]]

It's effectively a UniquePtr, let's make it less hard to reason about.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1454503: Remove unused RestyleManager refcounting.

Review commit: https://reviewboard.mozilla.org/r/237016/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/237016/

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1454503: Remove unneeded refcounting in nsAnimationManager / nsTransitionManager.

Review commit: https://reviewboard.mozilla.org/r/237034/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/237034/

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1454503: Remove unused nsFrameManager::mIsDestroyingFrames.

Review commit: https://reviewboard.mozilla.org/r/237036/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/237036/

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 8968341 [details]
Bug 1454503: Remove unused RestyleManager refcounting.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/237016/diff/1-2/

Comment 5

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8968341 [details]
Bug 1454503: Remove unused RestyleManager refcounting.

https://reviewboard.mozilla.org/r/237016/#review242848

Comment 6

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8968353 [details]
Bug 1454503: Remove unused nsFrameManager::mIsDestroyingFrames.

https://reviewboard.mozilla.org/r/237036/#review242850

Comment 7

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8968352 [details]
Bug 1454503: Remove unneeded refcounting in nsAnimationManager / nsTransitionManager.

https://reviewboard.mozilla.org/r/237034/#review242854

Nice!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/40a157e04cbc
Remove unused RestyleManager refcounting. r=xidorn
https://hg.mozilla.org/integration/mozilla-inbound/rev/761677ac644f
Remove unneeded refcounting in nsAnimationManager / nsTransitionManager. r=hiro
https://hg.mozilla.org/integration/mozilla-inbound/rev/617ce8cb79fb
Remove unused nsFrameManager::mIsDestroyingFrames. r=xidorn

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/40a157e04cbc
https://hg.mozilla.org/mozilla-central/rev/761677ac644f
https://hg.mozilla.org/mozilla-central/rev/617ce8cb79fb