Closed Bug 1454540 Opened 3 years ago Closed 3 years ago

WorkerPrivate::DispatchPrivate is unnecessary

Categories

(Core :: DOM: Workers, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: jimb, Assigned: jimb)

Details

Attachments

(1 file)

The only difference between WorkerPrivate::Dispatch and WorkerPrivate::DispatchPrivate is that the latter accepts an nsIEventTarget pointer, for which the former passes nullptr. It would be simpler to have a single function with a default argument.
Assignee: nobody → jimb
Status: NEW → ASSIGNED
Attachment #8968396 - Flags: review?(amarchesini)
Attachment #8968396 - Flags: review?(amarchesini) → review+
Priority: -- → P2
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/34322841fae5
Remove WorkerPrivate::DispatchPrivate, and give WorkerPrivate::Dispatch a default argument instead. r=baku
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/34322841fae5
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.