Closed
Bug 1454540
Opened 6 years ago
Closed 6 years ago
WorkerPrivate::DispatchPrivate is unnecessary
Categories
(Core :: DOM: Workers, enhancement, P2)
Core
DOM: Workers
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: jimb, Assigned: jimb)
Details
Attachments
(1 file)
The only difference between WorkerPrivate::Dispatch and WorkerPrivate::DispatchPrivate is that the latter accepts an nsIEventTarget pointer, for which the former passes nullptr. It would be simpler to have a single function with a default argument.
|
Assignee | |
Comment 1•6 years ago
|
||
|
||
Updated•6 years ago
|
Attachment #8968396 -
Flags: review?(amarchesini) → review+
|
||
Updated•6 years ago
|
Priority: -- → P2
|
|
Assignee | |
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/34322841fae5 Remove WorkerPrivate::DispatchPrivate, and give WorkerPrivate::Dispatch a default argument instead. r=baku
Keywords: checkin-needed
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/34322841fae5
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•