Closed Bug 1454550 Opened 2 years ago Closed 2 years ago

Skip calling AnimationHelper::SampleAnimationForEachNode if the layer has no animation

Categories

(Core :: DOM: Animation, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: hiro, Assigned: hiro)

Details

Attachments

(1 file)

Though we have an early return in AnimationHelper::SampleAnimationForEachNode() if there is no animation, we can avoid calling the function in the first place in such case.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=753df32a444db7171cc661809ac35df72983831b
Comment on attachment 8968398 [details]
Bug 1454550 - Call AnimationHelper::SampleAnimationForEachNode only for layers that have animations.

https://reviewboard.mozilla.org/r/237098/#review243020
Attachment #8968398 - Flags: review?(bugmail) → review+
Assignee: nobody → hikezoe
Status: NEW → ASSIGNED
Pushed by hikezoe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7197059eb99c
Call AnimationHelper::SampleAnimationForEachNode only for layers that have animations. r=kats
https://hg.mozilla.org/mozilla-central/rev/7197059eb99c
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.