Closed Bug 1454587 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 10502 - [css-align] Simple syntax for the Alignment shorthands

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 10502 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/10502
Details from upstream follow.

Javier Fernandez <jfernandez@igalia.com> wrote:
>  [css-align] Simple syntax for the Alignment shorthands
>  
>  Now that the issue [1] about the syntax ambiguity has bee resolved we
>  don´t need to use the custom syntax anymore. The Alignment shorthands
>  use now the simple syntax, defined based on the longhands' syntax.
>  
>  Since we allow all the values valid for each longhand, we'll update
>  in this CL the corresponding web platform tests. Additionally, this CL
>  updates also the shorthand serialization tests [2], which didn't
>  consider the new value 'legacy' for justify-items (and place-items) due
>  to the bug [3] Firefox still has pending to be fixed.
>  
>  
>  [1] https://github.com/w3c/csswg-drafts/issues/1001
>  [2] css/css-align/default-alignment/shorthand-serialization-001.html
>  [3] https://bugzilla.mozilla.org/show_bug.cgi?id=1363875
>  
>  Bug: 832503, 829806
>  Change-Id: I53f803b384cc55b0b38292540262e54f803586da
>  
>  Reviewed-on: https://chromium-review.googlesource.com/1013710
>  WPT-Export-Revision: 68d7611ed8b64c97cd0b8afbd5a1f1192da076f2
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Ran 44 tests and 2034 subtests
OK     : 44
PASS   : 1819
FAIL   : 215

New tests that have failures or other problems:
/css/css-align/content-distribution/place-content-shorthand-001.html
    Checking place-content: unsafe end: FAIL
    Checking place-content: unsafe flex-start: FAIL
/css/css-align/content-distribution/place-content-shorthand-002.html
    Checking place-content: unsafe end center: FAIL
    Checking place-content: unsafe end end: FAIL
    Checking place-content: unsafe end flex-end: FAIL
    Checking place-content: unsafe end flex-start: FAIL
    Checking place-content: unsafe end left: FAIL
    Checking place-content: unsafe end normal: FAIL
    Checking place-content: unsafe end right: FAIL
    Checking place-content: unsafe end space-around: FAIL
    Checking place-content: unsafe end space-between: FAIL
    Checking place-content: unsafe end space-evenly: FAIL
    Checking place-content: unsafe end start: FAIL
    Checking place-content: unsafe end stretch: FAIL
    Checking place-content: unsafe flex-start center: FAIL
    Checking place-content: unsafe flex-start end: FAIL
    Checking place-content: unsafe flex-start flex-end: FAIL
    Checking place-content: unsafe flex-start flex-start: FAIL
    Checking place-content: unsafe flex-start left: FAIL
    Checking place-content: unsafe flex-start normal: FAIL
    Checking place-content: unsafe flex-start right: FAIL
    Checking place-content: unsafe flex-start space-around: FAIL
    Checking place-content: unsafe flex-start space-between: FAIL
    Checking place-content: unsafe flex-start space-evenly: FAIL
    Checking place-content: unsafe flex-start start: FAIL
    Checking place-content: unsafe flex-start stretch: FAIL
/css/css-align/default-alignment/place-items-shorthand-001.html
    Checking place-items: unsafe end: FAIL
    Checking place-items: unsafe flex-start: FAIL
/css/css-align/default-alignment/place-items-shorthand-002.html
    Checking place-items: baseline unsafe end: FAIL
    Checking place-items: baseline unsafe flex-start: FAIL
    Checking place-items: center unsafe end: FAIL
    Checking place-items: center unsafe flex-start: FAIL
    Checking place-items: end unsafe end: FAIL
    Checking place-items: end unsafe flex-start: FAIL
    Checking place-items: first baseline unsafe end: FAIL
    Checking place-items: first baseline unsafe flex-start: FAIL
    Checking place-items: flex-end unsafe end: FAIL
    Checking place-items: flex-end unsafe flex-start: FAIL
    Checking place-items: flex-start unsafe end: FAIL
    Checking place-items: flex-start unsafe flex-start: FAIL
    Checking place-items: last baseline unsafe end: FAIL
    Checking place-items: last baseline unsafe flex-start: FAIL
    Checking place-items: normal unsafe end: FAIL
    Checking place-items: normal unsafe flex-start: FAIL
    Checking place-items: safe center unsafe end: FAIL
    Checking place-items: safe center unsafe flex-start: FAIL
    Checking place-items: safe end unsafe end: FAIL
    Checking place-items: safe end unsafe flex-start: FAIL
    Checking place-items: safe flex-end unsafe end: FAIL
    Checking place-items: safe flex-end unsafe flex-start: FAIL
    Checking place-items: self-end unsafe end: FAIL
    Checking place-items: self-end unsafe flex-start: FAIL
    Checking place-items: self-start unsafe end: FAIL
    Checking place-items: self-start unsafe flex-start: FAIL
    Checking place-items: start unsafe end: FAIL
    Checking place-items: start unsafe flex-start: FAIL
    Checking place-items: stretch unsafe end: FAIL
    Checking place-items: stretch unsafe flex-start: FAIL
    Checking place-items: unsafe end baseline: FAIL
    Checking place-items: unsafe end center: FAIL
    Checking place-items: unsafe end end: FAIL
    Checking place-items: unsafe end first baseline: FAIL
    Checking place-items: unsafe end flex-end: FAIL
    Checking place-items: unsafe end flex-start: FAIL
    Checking place-items: unsafe end last baseline: FAIL
    Checking place-items: unsafe end left: FAIL
    Checking place-items: unsafe end legacy center: FAIL
    Checking place-items: unsafe end legacy left: FAIL
    Checking place-items: unsafe end legacy right: FAIL
    Checking place-items: unsafe end normal: FAIL
    Checking place-items: unsafe end right: FAIL
    Checking place-items: unsafe end safe center: FAIL
    Checking place-items: unsafe end safe end: FAIL
    Checking place-items: unsafe end safe flex-end: FAIL
    Checking place-items: unsafe end self-end: FAIL
    Checking place-items: unsafe end self-start: FAIL
    Checking place-items: unsafe end start: FAIL
    Checking place-items: unsafe end stretch: FAIL
    Checking place-items: unsafe end unsafe end: FAIL
    Checking place-items: unsafe end unsafe flex-start: FAIL
    Checking place-items: unsafe flex-start baseline: FAIL
    Checking place-items: unsafe flex-start center: FAIL
    Checking place-items: unsafe flex-start end: FAIL
    Checking place-items: unsafe flex-start first baseline: FAIL
    Checking place-items: unsafe flex-start flex-end: FAIL
    Checking place-items: unsafe flex-start flex-start: FAIL
    Checking place-items: unsafe flex-start last baseline: FAIL
    Checking place-items: unsafe flex-start left: FAIL
    Checking place-items: unsafe flex-start legacy center: FAIL
    Checking place-items: unsafe flex-start legacy left: FAIL
    Checking place-items: unsafe flex-start legacy right: FAIL
    Checking place-items: unsafe flex-start normal: FAIL
    Checking place-items: unsafe flex-start right: FAIL
    Checking place-items: unsafe flex-start safe center: FAIL
    Checking place-items: unsafe flex-start safe end: FAIL
    Checking place-items: unsafe flex-start safe flex-end: FAIL
    Checking place-items: unsafe flex-start self-end: FAIL
    Checking place-items: unsafe flex-start self-start: FAIL
    Checking place-items: unsafe flex-start start: FAIL
    Checking place-items: unsafe flex-start stretch: FAIL
    Checking place-items: unsafe flex-start unsafe end: FAIL
    Checking place-items: unsafe flex-start unsafe flex-start: FAIL
/css/css-align/default-alignment/shorthand-serialization-001.html
    test shorthand serialization {"alignItems":"baseline","shorthand":"baseline legacy"}: FAIL
    test shorthand serialization {"alignItems":"center","shorthand":"center legacy"}: FAIL
/css/css-align/self-alignment/place-self-shorthand-001.html
    Checking place-self: unsafe end: FAIL
    Checking place-self: unsafe flex-start: FAIL
/css/css-align/self-alignment/place-self-shorthand-002.html
    Checking place-self: auto unsafe end: FAIL
    Checking place-self: auto unsafe flex-start: FAIL
    Checking place-self: baseline unsafe end: FAIL
    Checking place-self: baseline unsafe flex-start: FAIL
    Checking place-self: center unsafe end: FAIL
    Checking place-self: center unsafe flex-start: FAIL
    Checking place-self: end unsafe end: FAIL
    Checking place-self: end unsafe flex-start: FAIL
    Checking place-self: first baseline unsafe end: FAIL
    Checking place-self: first baseline unsafe flex-start: FAIL
    Checking place-self: flex-end unsafe end: FAIL
    Checking place-self: flex-end unsafe flex-start: FAIL
    Checking place-self: flex-start unsafe end: FAIL
    Checking place-self: flex-start unsafe flex-start: FAIL
    Checking place-self: last baseline unsafe end: FAIL
    Checking place-self: last baseline unsafe flex-start: FAIL
    Checking place-self: normal unsafe end: FAIL
    Checking place-self: normal unsafe flex-start: FAIL
    Checking place-self: safe center unsafe end: FAIL
    Checking place-self: safe center unsafe flex-start: FAIL
    Checking place-self: safe end unsafe end: FAIL
    Checking place-self: safe end unsafe flex-start: FAIL
    Checking place-self: safe flex-end unsafe end: FAIL
    Checking place-self: safe flex-end unsafe flex-start: FAIL
    Checking place-self: self-end unsafe end: FAIL
    Checking place-self: self-end unsafe flex-start: FAIL
    Checking place-self: self-start unsafe end: FAIL
    Checking place-self: self-start unsafe flex-start: FAIL
    Checking place-self: start unsafe end: FAIL
    Checking place-self: start unsafe flex-start: FAIL
    Checking place-self: stretch unsafe end: FAIL
    Checking place-self: stretch unsafe flex-start: FAIL
    Checking place-self: unsafe end auto: FAIL
    Checking place-self: unsafe end baseline: FAIL
    Checking place-self: unsafe end center: FAIL
    Checking place-self: unsafe end end: FAIL
    Checking place-self: unsafe end first baseline: FAIL
    Checking place-self: unsafe end flex-end: FAIL
    Checking place-self: unsafe end flex-start: FAIL
    Checking place-self: unsafe end last baseline: FAIL
    Checking place-self: unsafe end left: FAIL
    Checking place-self: unsafe end normal: FAIL
    Checking place-self: unsafe end right: FAIL
    Checking place-self: unsafe end safe center: FAIL
    Checking place-self: unsafe end safe end: FAIL
    Checking place-self: unsafe end safe flex-end: FAIL
    Checking place-self: unsafe end self-end: FAIL
    Checking place-self: unsafe end self-start: FAIL
    Checking place-self: unsafe end start: FAIL
    Checking place-self: unsafe end stretch: FAIL
    Checking place-self: unsafe end unsafe end: FAIL
    Checking place-self: unsafe end unsafe flex-start: FAIL
    Checking place-self: unsafe flex-start auto: FAIL
    Checking place-self: unsafe flex-start baseline: FAIL
    Checking place-self: unsafe flex-start center: FAIL
    Checking place-self: unsafe flex-start end: FAIL
    Checking place-self: unsafe flex-start first baseline: FAIL
    Checking place-self: unsafe flex-start flex-end: FAIL
    Checking place-self: unsafe flex-start flex-start: FAIL
    Checking place-self: unsafe flex-start last baseline: FAIL
    Checking place-self: unsafe flex-start left: FAIL
    Checking place-self: unsafe flex-start normal: FAIL
    Checking place-self: unsafe flex-start right: FAIL
    Checking place-self: unsafe flex-start safe center: FAIL
    Checking place-self: unsafe flex-start safe end: FAIL
    Checking place-self: unsafe flex-start safe flex-end: FAIL
    Checking place-self: unsafe flex-start self-end: FAIL
    Checking place-self: unsafe flex-start self-start: FAIL
    Checking place-self: unsafe flex-start start: FAIL
    Checking place-self: unsafe flex-start stretch: FAIL
    Checking place-self: unsafe flex-start unsafe end: FAIL
    Checking place-self: unsafe flex-start unsafe flex-start: FAIL
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fba98c6ad8e5
[wpt PR 10502] - [css-align] Simple syntax for the Alignment shorthands, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/9c15c6606d31
[wpt PR 10502] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/fba98c6ad8e5
https://hg.mozilla.org/mozilla-central/rev/9c15c6606d31
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.