1454628 - "mozilla/a11y/IPCTypes.h(10): fatal error C1083: Cannot open include file: 'mozilla/a11y/Role.h': No such file or directory" with --disable-accessibility

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Comment 1

[Alex Gaynor [:Alex_Gaynor]]

Can you include the full error log? (Hoping to see where IPCTypes.h is being included from)

Comment 2

[Alex Gaynor [:Alex_Gaynor]]

Ok, here's the hard chain:

 2:32.23 In file included from /Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin17.5.0/ipc/ipdl/UnifiedProtocols11.cpp:38:
 2:32.23 In file included from /Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin17.5.0/ipc/ipdl/PDocAccessible.cpp:12:
 2:32.23 /Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin17.5.0/ipc/ipdl/_ipdlheaders/mozilla/a11y/PDocAccessible.h:20:10: fatal error: 'mozilla/a11y/Role.h' file not found
 2:32.23 #include "mozilla/a11y/Role.h"
 2:32.23          ^~~~~~~~~~~~~~~~~~~~~
 2:32.23 1 error generated.

PDocAccessible uses a11y::Role, but Role is defined in accessible/base/Role.h, which isn't built in disable-accessibility builds.

aklotz, I don't know how this code is put together very well. Bug 1453979 was simply trying to use the defined enum in the protocols where it's used, but I hadn't realized how disable-accessibility builds interacted with it. Do you have any suggestion for how to resolve?

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

I'd suggest declaring a11y::Role as a dummy type when ACCESSIBILITY is not defined.

Take a look at accessible/ipc/IPCTypes.h for an example.

Comment 4

[Alex Gaynor [:Alex_Gaynor]]

Attachment: Bug 1454628 - fixed compilation with --disable-accessibility builds;

This was broken by bug 1453979.

Review commit: https://reviewboard.mozilla.org/r/237288/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/237288/

Comment 5

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 8968598 [details]
Bug 1454628 - fixed compilation with --disable-accessibility builds;

https://reviewboard.mozilla.org/r/237288/#review243094

::: accessible/ipc/IPCTypes.h:21
(Diff revision 1)
>  struct ParamTraits<mozilla::a11y::role>
>    : public ContiguousEnumSerializerInclusive<mozilla::a11y::role,
>                                               mozilla::a11y::role::NOTHING,
>                                               mozilla::a11y::role::LAST_ROLE>
>  {
>  };

Nit: Please add a blank line between the end of the template specialization and the end of the namespace.

::: accessible/ipc/IPCTypes.h:22
(Diff revision 1)
>    : public ContiguousEnumSerializerInclusive<mozilla::a11y::role,
>                                               mozilla::a11y::role::NOTHING,
>                                               mozilla::a11y::role::LAST_ROLE>
>  {
>  };
>  };

Nit: You don't need a semicolon when closing the namespace.

::: accessible/ipc/IPCTypes.h:27
(Diff revision 1)
>  };
> +#else
> +namespace mozilla {
> +namespace a11y {
> +typedef uint32_t role;
> +}

Can you please add comments indicating which namespace each closing brace corresponds to?

e.g.

} // namespace a11y

Comment 6

[Alex Gaynor [:Alex_Gaynor]]

Comment on attachment 8968598 [details]
Bug 1454628 - fixed compilation with --disable-accessibility builds;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/237288/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/37f7d1dde982
fixed compilation with --disable-accessibility builds; r=aklotz

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/37f7d1dde982