Closed Bug 1454629 Opened Last year Closed Last year

Exclude Visual Studio header files from coverage reports

Categories

(Testing :: Code Coverage, enhancement)

enhancement
Not set

Tracking

(firefox61 fixed)

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: marco, Assigned: marco)

References

Details

Attachments

(2 files)

Right now we are excluding gcc header files (https://dxr.mozilla.org/mozilla-central/rev/6276ec7ebbf33e3484997b189f20fc1511534187/testing/mozharness/mozharness/mozilla/testing/codecoverage.py#194), but not Visual Studio ones.

The Visual Studio directory is vs2017_15.6.6, so it depends on the version.

In order to do this, we will need:
- https://github.com/marco-c/grcov/issues/87 (make grcov support ignoring multiple directories)
- https://github.com/marco-c/grcov/issues/86 (make grcov support ignoring directories with wildcards, because we want to ignore "vs2017_*" and not just "vs2017_15.6.6" as we don't want to update the string when we update the compiler)

This should reduce the size of coverage reports.
I've added the two needed features to grcov, now I need to generate a new grcov build and upload it to tooltool.
Assignee: nobody → mcastelluccio
Status: NEW → ASSIGNED
Attachment #8969186 - Flags: review?(jmaher)
The zipped grcov info file for GTest went down from 38,1 MB to 31,4 MB.
The uncompressed info file from 317 MB to 247,2 MB.
So more or less a 20% reduction.

The genhtml report size is reduced by ~2 GB (some Visual Studio headers contain tens of thousands of functions).
Attachment #8969187 - Flags: review?(jmaher)
Pushed by mcastelluccio@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7d99a84cebf3
Update grcov to version 0.1.34. r=jmaher
https://hg.mozilla.org/integration/mozilla-inbound/rev/c30785b6f3f7
Ignore both gcc and Visual Studio headers in coverage reports. r=jmaher
Blocks: 1455400
Blocks: 1455401
Blocks: 1455403
No longer blocks: 1455403
No longer blocks: 1455401
No longer blocks: 1455400
https://hg.mozilla.org/mozilla-central/rev/7d99a84cebf3
https://hg.mozilla.org/mozilla-central/rev/c30785b6f3f7
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.