Closed Bug 1454635 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 10504 - Fix wpt/css/CSS2/floats-clear/clear-on-parent-with-margins-no-clearance.html

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla61
Tracking Flags:
Tracking Status
firefox61 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 10504 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/10504
Details from upstream follow.

Morten Stenshorne <mstensho@chromium.org> wrote:
>  Fix wpt/css/CSS2/floats-clear/clear-on-parent-with-margins-no-clearance.html
>  
>  The test was incorrect, which is why it failed in legacy layout. It
>  passed in LayoutNG because of a bug there.
>  
>  Add an (invisible) top border on the outer DIV to prevent clearance on
>  the child. Otherwise the outer DIV and the child with 'clear' would have
>  adjacent margins, which in turn would enable the child with 'clear' to
>  pull the float along with itself, which in turn would guarantee
>  clearance, which is precisely what this test wanted to avoid.
>  
>  Still passes in LayoutNG.
>  
>  Change-Id: I6b36d8196b93720453d6e398509705d2cf32f8e4
>  Reviewed-on: https://chromium-review.googlesource.com/1014975
>  WPT-Export-Revision: 016f5ea3cdb5084f9496c99397013ccb968e7dd3
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Ran 1 tests
PASS   : 1
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8b2fa0ca8b29
[wpt PR 10504] - Fix wpt/css/CSS2/floats-clear/clear-on-parent-with-margins-no-clearance.html, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/3e57674c17aa
[wpt PR 10504] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/8b2fa0ca8b29
https://hg.mozilla.org/mozilla-central/rev/3e57674c17aa
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.