Closed
Bug 1454635
Opened 7 years ago
Closed 7 years ago
[wpt-sync] Sync PR 10504 - Fix wpt/css/CSS2/floats-clear/clear-on-parent-with-margins-no-clearance.html
Categories
(Core :: CSS Parsing and Computation, enhancement, P4)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 10504 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/w3c/web-platform-tests/pull/10504
Details from upstream follow.
Morten Stenshorne <mstensho@chromium.org> wrote:
> Fix wpt/css/CSS2/floats-clear/clear-on-parent-with-margins-no-clearance.html
>
> The test was incorrect, which is why it failed in legacy layout. It
> passed in LayoutNG because of a bug there.
>
> Add an (invisible) top border on the outer DIV to prevent clearance on
> the child. Otherwise the outer DIV and the child with 'clear' would have
> adjacent margins, which in turn would enable the child with 'clear' to
> pull the float along with itself, which in turn would guarantee
> clearance, which is precisely what this test wanted to avoid.
>
> Still passes in LayoutNG.
>
> Change-Id: I6b36d8196b93720453d6e398509705d2cf32f8e4
> Reviewed-on: https://chromium-review.googlesource.com/1014975
> WPT-Export-Revision: 016f5ea3cdb5084f9496c99397013ccb968e7dd3
Reporter | ||
Updated•7 years ago
|
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Reporter | ||
Comment 1•7 years ago
|
||
Reporter | ||
Comment 2•7 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=f8e5b0d48adc5bcadf38b8ac2fba87672dacd8f7
Reporter | ||
Comment 3•7 years ago
|
||
Reporter | ||
Comment 4•7 years ago
|
||
Ran 1 tests
PASS : 1
Reporter | ||
Comment 5•7 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=b50d52d21971b6d612f973552050db85021a11c0
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8b2fa0ca8b29
[wpt PR 10504] - Fix wpt/css/CSS2/floats-clear/clear-on-parent-with-margins-no-clearance.html, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/3e57674c17aa
[wpt PR 10504] - Update wpt metadata, a=testonly
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8b2fa0ca8b29
https://hg.mozilla.org/mozilla-central/rev/3e57674c17aa
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•