Closed
Bug 1454646
Opened 6 years ago
Closed 6 years ago
land some ServiceWorkerContainer refactoring to inner object
Categories
(Core :: DOM: Service Workers, enhancement, P2)
Core
DOM: Service Workers
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: bkelly, Assigned: bkelly)
References
Details
Attachments
(5 files)
9.63 KB,
patch
|
bkelly
:
review+
|
Details | Diff | Splinter Review |
4.31 KB,
patch
|
bkelly
:
review+
|
Details | Diff | Splinter Review |
15.15 KB,
patch
|
bkelly
:
review+
|
Details | Diff | Splinter Review |
7.65 KB,
patch
|
bkelly
:
review+
|
Details | Diff | Splinter Review |
13.20 KB,
patch
|
bkelly
:
review+
|
Details | Diff | Splinter Review |
Splitting this off from bug 1436812 to land some initial patches that are ready to go.
Updated•6 years ago
|
Priority: -- → P2
Assignee | ||
Comment 1•6 years ago
|
||
Attachment #8968537 -
Flags: review+
Assignee | ||
Comment 2•6 years ago
|
||
Assignee | ||
Comment 3•6 years ago
|
||
Assignee | ||
Comment 4•6 years ago
|
||
Assignee | ||
Comment 5•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Attachment #8968538 -
Flags: review+
Assignee | ||
Updated•6 years ago
|
Attachment #8968539 -
Flags: review+
Assignee | ||
Updated•6 years ago
|
Attachment #8968540 -
Flags: review+
Assignee | ||
Updated•6 years ago
|
Attachment #8968541 -
Flags: review+
Pushed by bkelly@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/d56a387c8b36 P1 Add a ServiceWorkerContainer::Inner scaffold. r=baku https://hg.mozilla.org/integration/mozilla-inbound/rev/e3a22120dd0c P2 Implement ServiceWorkerContainer::GetReady() via the Inner class. r=baku https://hg.mozilla.org/integration/mozilla-inbound/rev/7dcfb609b250 P3 Implement ServiceWorkerContainer::GetRegistration() via the inner clas. r=baku https://hg.mozilla.org/integration/mozilla-inbound/rev/b166c60892d3 P4 Factor out a method for checking global validity in ServiceWorkerContainer to reduce code duplication. r=baku https://hg.mozilla.org/integration/mozilla-inbound/rev/42ad33390fcc P5 Implement ServiceWorkerContainer::GetRegistrations() via the inner class. r=baku
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d56a387c8b36 https://hg.mozilla.org/mozilla-central/rev/e3a22120dd0c https://hg.mozilla.org/mozilla-central/rev/7dcfb609b250 https://hg.mozilla.org/mozilla-central/rev/b166c60892d3 https://hg.mozilla.org/mozilla-central/rev/42ad33390fcc
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•