Closed Bug 1454682 Opened 6 years ago Closed 6 years ago

Update mergeday configuration for the new esr60 branch

Categories

(Release Engineering :: Release Requests, defect)

defect
Not set
normal

Tracking

(firefox61 fixed)

RESOLVED FIXED
Tracking Status
firefox61 --- fixed

People

(Reporter: jlorenzo, Assigned: jlorenzo)

References

Details

Attachments

(1 file)

I came across a few outdated bits when I ran the scripts from mozilla-beta to jamun. Details in upcoming patch.
Comment on attachment 8968570 [details]
Bug 1454682 - Update mergeday configuration for the new esr60 branch

https://reviewboard.mozilla.org/r/237262/#review243072

::: testing/mozharness/configs/merge_day/release_to_esr.py
(Diff revision 1)
> -        ("build/mozconfig.common",
> -         "# Enable checking that add-ons are signed by the trusted root",
> -         "# Disable checking that add-ons are signed by the trusted root"),
> -        ("build/mozconfig.common",
> -         "MOZ_ADDON_SIGNING=${MOZ_ADDON_SIGNING-1}",
> -         "MOZ_ADDON_SIGNING=${MOZ_ADDON_SIGNING-0}"),

I think we still want this to be disabled. The idea is that the "corporate" users know what they install.
Comment on attachment 8968570 [details]
Bug 1454682 - Update mergeday configuration for the new esr60 branch

https://reviewboard.mozilla.org/r/237262/#review243080

::: testing/mozharness/configs/merge_day/release_to_esr.py
(Diff revision 1)
> -        ("build/mozconfig.common",
> -         "# Enable checking that add-ons are signed by the trusted root",
> -         "# Disable checking that add-ons are signed by the trusted root"),
> -        ("build/mozconfig.common",
> -         "MOZ_ADDON_SIGNING=${MOZ_ADDON_SIGNING-1}",
> -         "MOZ_ADDON_SIGNING=${MOZ_ADDON_SIGNING-0}"),

Good catch! I thought Firefox 57+ would enforce signatures. I know from Callek that addons can be signed on AMO and organizations can keep them private. This is for the case of internal addons.


However, I checked with :aswan. They likely want to keep the ESR behavior like it was on ESR52. Waiting to hear from :kev to be sure.

In the meantime, I removed my changes.
Leaving NI on :kev to chime about comment 3.
Flags: needinfo?(kev)
Comment on attachment 8968570 [details]
Bug 1454682 - Update mergeday configuration for the new esr60 branch

https://reviewboard.mozilla.org/r/237262/#review243364
Attachment #8968570 - Flags: review?(rail) → review+
Great news! In bug 1447399, :mkaply requested to stop the custom branding in 60. I updated the patch to remove the graft piece. NI'ing Rail so he acknowledges the changes
Flags: needinfo?(rail)
Yay! Feel free to remove the grafting code as well!
Flags: needinfo?(rail)
(In reply to Rail Aliiev [:rail] ⌚️ET from comment #10)
Done in latest diff. I checked "graft(" isn't used anywhere in the repo.
Pushed by jlorenzo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ed1028a2a78c
Update mergeday configuration for the new esr60 branch r=rail
FYI to release duty: You need this patch to perform the mozilla-release => esr60 migration. Please update the mozharness scripts to what's on central whenever it makes it there.
Flags: needinfo?(sfraser)
Flags: needinfo?(aki)
https://hg.mozilla.org/mozilla-central/rev/ed1028a2a78c
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
This is now in the merge day instance's copy of mozharness-central
Flags: needinfo?(sfraser)
Flags: needinfo?(kev)
Flags: needinfo?(aki)
You need to log in before you can comment on or make changes to this bug.