Closed Bug 1454728 Opened Last year Closed Last year

[BinAST] Create recursive bindings for function expressions

Categories

(Core :: JavaScript Engine, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: efaust, Assigned: efaust)

Details

Attachments

(2 files)

This bug has as the kind side effect that we now get the proper allocation size and JSFunction flags for most upcoming function types (In particular, method definition syntax productions).
Attachment #8968624 - Flags: review?(dteller)
Assignee: nobody → efaustbmo
Status: NEW → ASSIGNED
Comment on attachment 8968624 [details] [diff] [review]
expressionBinding.patch

Review of attachment 8968624 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm, thanks!
Don't forget to PR the webidl changes to upstream, otherwise we'll end up with an incompatible encoder.
Attachment #8968624 - Flags: review?(dteller) → review+
Comment on attachment 8968624 [details] [diff] [review]
expressionBinding.patch

Review of attachment 8968624 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, but I suspect that it's going going to need some rebasing.
Priority: -- → P2
Attachment #8972229 - Flags: review?(arai.unmht) → review+
Pushed by efaustbmo@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5bf7bfe1db79
[BinAST] Create recursive bindings for function expressions. (r=Yoric, r=arai)
https://hg.mozilla.org/mozilla-central/rev/5bf7bfe1db79
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.