1454730 - Change the background fill colour for Top Sites with transparency (Dark Theme)

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P2)

Description

[Amy Lee [:amylee] UX]

Attachment: Screen Shot 2018-04-11 at 1.26.09 PM.png

Can we change the background fill colour to Top Sites that have transparency? Right now it's set to white #FFFFFF but it's looking pretty harsh on dark theme, can we change the colour to Grey 70 #38383D. 

See current screenshot for reference. Thanks!

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4103

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/d921a0b37efc1e200c8a5b75c24c401f68948ed5
Fix Bug 1454730 - change Top Site icon background to grey-70 on dark theme

https://github.com/mozilla/activity-stream/commit/f5c91b0d3bc3c58bf2269ce4a5ddc1d67b7d67b5
Merge pull request #4103 from rlr/Bug1454730/topsites-background

Fix Bug 1454730 - change Top Site icon background to grey-70 on dark theme

Comment 3

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/5d2486077e4b

Comment 4

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

Build ID 	20180422223305
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0

I have verified that the issue is no longer reproducible on the latest Nightly build on Windows 10 x64, Mac 10.13.3 and Arch Linux x64 with Dark Theme enabled.