Closed Bug 1454747 Opened 2 years ago Closed 2 years ago

Assert more tightly in nsCSSFrameConstructor::StyleNewChildRange.

Categories

(Core :: CSS Parsing and Computation, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(1 file)

Now that bug 1303605 enforces LazyFC invariants, we can remove the handwavyness from here.
Comment on attachment 8968640 [details]
Bug 1454747: Assert more tightly about StyleNewChildRange.

https://reviewboard.mozilla.org/r/237324/#review244062
Attachment #8968640 - Flags: review?(bzbarsky) → review+
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/67b2c258a4d4
Assert more tightly about StyleNewChildRange. r=bz
Backed out changeset 67b2c258a4d4 (bug 1454747) for failures on nsCSSFrameConstructor.cpp:7031 on a CLOSED TREE

Backout link: https://hg.mozilla.org/integration/autoland/rev/6ed42cf2f0dd53c5ea7fd81230ad3288b624b9b2

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=67b2c258a4d43fa8face88cb55c29cca0955b6e7

Log link: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=67b2c258a4d43fa8face88cb55c29cca0955b6e7

Log snippet: 
[task 2018-04-20T09:21:05.726Z] 09:21:05     INFO -  REFTEST TEST-START | http://10.0.2.2:8888/tests/layout/base/crashtests/376223-1.xhtml
[task 2018-04-20T09:21:05.726Z] 09:21:05     INFO -  REFTEST TEST-LOAD | http://10.0.2.2:8888/tests/layout/base/crashtests/376223-1.xhtml | 12 / 354 (3%)
[task 2018-04-20T09:21:26.763Z] 09:21:26     INFO -  INFO | automation.py | Application ran for: 0:04:28.006290
[task 2018-04-20T09:21:26.764Z] 09:21:26     INFO -  INFO | zombiecheck | Reading PID log: /tmp/tmpd5INbPpidlog
[task 2018-04-20T09:21:27.381Z] 09:21:27     INFO -  /data/tombstones does not exist; tombstone check skipped
[task 2018-04-20T09:21:28.198Z] 09:21:28     INFO -  REFTEST INFO | Copy/paste: /usr/local/bin/linux64-minidump_stackwalk /tmp/tmpQOOaYU/41bb1293-f78b-e331-4ffd-356ffaa3583d.dmp /builds/worker/workspace/build/symbols
[task 2018-04-20T09:21:37.691Z] 09:21:37     INFO -  REFTEST INFO | Saved minidump as /builds/worker/workspace/build/blobber_upload_dir/41bb1293-f78b-e331-4ffd-356ffaa3583d.dmp
[task 2018-04-20T09:21:37.691Z] 09:21:37     INFO -  REFTEST INFO | Saved app info as /builds/worker/workspace/build/blobber_upload_dir/41bb1293-f78b-e331-4ffd-356ffaa3583d.extra
[task 2018-04-20T09:21:37.694Z] 09:21:37     INFO -  REFTEST PROCESS-CRASH | http://10.0.2.2:8888/tests/layout/base/crashtests/376223-1.xhtml | application crashed [@ nsCSSFrameConstructor::StyleNewChildRange]
[task 2018-04-20T09:21:37.694Z] 09:21:37     INFO -  Crash dump filename: /tmp/tmpQOOaYU/41bb1293-f78b-e331-4ffd-356ffaa3583d.dmp
Flags: needinfo?(emilio)
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/66e90ca48094
Assert more tightly about StyleNewChildRange. r=bz
I think I landed it in the wrong tree, since IIRC this required my other listbox changes to be green. I couldn't repro that failure at all.
Flags: needinfo?(emilio)
https://hg.mozilla.org/mozilla-central/rev/66e90ca48094
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.