Closed Bug 1454790 Opened 2 years ago Closed 2 years ago

Update strings for Firefox 60

Categories

(Firefox :: New Tab Page, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 60
Tracking Status
firefox60 + fixed
firefox61 --- unaffected

People

(Reporter: Mardak, Assigned: rrosario)

References

Details

User Story

https://github.com/mozilla/activity-stream/compare/e56482e6e778d4fa0396d36eee59f2fcbbbd3e69...bb34232e31931dfc11e2cbe5621211fb4dec6f45

Attachments

(2 files)

[Tracking Requested - why for this release]: Strings were last updated 6 weeks ago as part of nightly 60 that made it to 60b3 as part of bug 1444522.
User Story: (updated)
Attached image ach: before / after
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Comment on attachment 8968680 [details]
Bug 1454790 - Update strings for Firefox 60

https://reviewboard.mozilla.org/r/237354/#review243162

Remove the npm-debug.log file

::: browser/extensions/activity-stream/test/npm-debug.log:1
(Diff revision 1)
> +0 info it worked if it ends with ok

oops!
Attachment #8968680 - Flags: review?(edilee) → review+
Assignee: edilee → rrosario
Blocks: 1454807
User Story: (updated)
To be clear, attachment 8968680 [details] is for mozilla-beta
Comment on attachment 8968680 [details]
Bug 1454790 - Update strings for Firefox 60

Approval Request Comment
[Feature/Bug causing the regression]: Activity Stream new features in 60
[User impact if declined]: Untranslated or outdated strings for ~70 locales
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Not all -- most strings have been in nightly 60 for a while, but some locales had more recent changes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: The changes depend on bug 1454743 landing first, and this one blocks bug 1454807.
[Is the change risky?]: No
[Why is the change risky/not risky?]: Strings only changes
[String changes made/needed]: Yes, these are the translated strings from pontoon.

flod from a previous update strings bug: Note that this patch doesn't require l10n=XXX in the commit message, it doesn't touch .properties files, and localization happens outside of m-c. It's good to uplift from a l10n point of view.
Attachment #8968680 - Flags: approval-mozilla-beta?
Comment on attachment 8968680 [details]
Bug 1454790 - Update strings for Firefox 60

AS l10n update, approved for 60.0b14
Attachment #8968680 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.