Closed Bug 1454794 Opened 6 years ago Closed 2 years ago

Intermittent async-scrolling/bg-fixed-in-css-filter.html == async-scrolling/bg-fixed-in-css-filter-ref.html | image comparison, max difference: 1, number of differing pixels: 59

Categories

(Core :: Graphics: WebRender, defect, P5)

defect

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: intermittent-bug-filer, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: intermittent-failure, regression, Whiteboard: [retriggered])

Filed by: ncsoregi [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=174155908&repo=autoland

https://queue.taskcluster.net/v1/task/VCHCkoRZQNShc48pyTwWRw/runs/0/artifacts/public/logs/live_backing.log

https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/VCHCkoRZQNShc48pyTwWRw/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

[task 2018-04-17T17:58:29.118Z] 17:58:29     INFO - REFTEST TEST-START | file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/async-scrolling/bg-fixed-in-css-filter.html == file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/async-scrolling/bg-fixed-in-css-filter-ref.html
[task 2018-04-17T17:58:29.119Z] 17:58:29     INFO - REFTEST TEST-LOAD | file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/async-scrolling/bg-fixed-in-css-filter.html | 9 / 69 (13%)
[task 2018-04-17T17:58:29.135Z] 17:58:29     INFO - ++DOMWINDOW == 29 (0x7fbdf1a4b000) [pid = 3653] [serial = 30] [outer = 0x7fbdf6c46000]
[task 2018-04-17T17:58:29.768Z] 17:58:29     INFO - REFTEST TEST-LOAD | file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/async-scrolling/bg-fixed-in-css-filter-ref.html | 9 / 69 (13%)
[task 2018-04-17T17:58:29.789Z] 17:58:29     INFO - ++DOMWINDOW == 30 (0x7fbdf1a4dc00) [pid = 3653] [serial = 31] [outer = 0x7fbdf6c46000]
[task 2018-04-17T17:58:30.572Z] 17:58:30     INFO - REFTEST TEST-UNEXPECTED-FAIL | file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/async-scrolling/bg-fixed-in-css-filter.html == file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/async-scrolling/bg-fixed-in-css-filter-ref.html | image comparison, max difference: 1, number of differing pixels: 59
Filed for QuantumRender, with a handful of barely-fuzzy pixels around the fringes of a filtered element.

Unless we get reports on another platform, it seems likely this is QuantumRender-specific --> reclassifying.

(If needed, it looks like this could be easily worked around with a fuzzy-if annotation.)
Component: Layout → Graphics: WebRender
Did some retriggers and found that 25% of the jobs are failing.
It seems that the failure started here: 
https://treeherder.mozilla.org/#/jobs?repo=autoland&filter-searchStr=debug-reftest-e10s-2&tochange=118b16b6ab5d880813f2d5904effad16ca3dcfaf&fromchange=a6bd62970a9fb094f223d99fbdf3dac25ec2f42d&selectedJob=174546061
Flags: needinfo?(jmaher)
Whiteboard: [retriggered]
Thanks Noemi, this is great information.  It does in fact look related to bug 1453688, :kats, is this something you want to fuzzy-if for webrender, or look into the update from bug 1453688 ?
Blocks: 1453688
Flags: needinfo?(jmaher) → needinfo?(bugmail)
I'll probably end up fuzzy-if'ing it, but I'm doing retriggers on the try pushes in that bug to see which upstream webrender change introduced it. /me doesn't like nondeterministic behaviour
Assignee: nobody → bugmail
Flags: needinfo?(bugmail)
Based on retriggers on https://treeherder.mozilla.org/#/jobs?repo=try&revision=4596e218893d805e3bac46188edbf7c7255d3224&group_state=expanded and https://treeherder.mozilla.org/#/jobs?repo=try&revision=88a378263fca4e4cbdb349df61cb1f74c25380e1&group_state=expanded it seems to have been introduced by this range:

*   565e2408 Auto merge of #2661 - jrmuizel:tiled-blob-renderer, r=kvark
|\
| * 71cb1d0a wrench/blob: Only paint the dirty rect
* fba1b411 Auto merge of #2651 - glennw:cache-text-shadow-3, r=kvark
* d48fe709 Add basic infrastructure for caching Pictures, enable for some blurs.

i.e. from servo/webrender#2651 (the other PR just touched wrench).
Filed https://github.com/servo/webrender/issues/2675 for it upstream. I'll land a fuzzing patch, but let's keep this open until the underlying issue is fixed.
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f5e8a0417a5
Fuzz an intermittent failure introduced by WR PR 2651. r=me
Assignee: bugmail → nobody
Blocks: stage-wr-next
No longer blocks: stage-wr-trains

Appears fixed.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.