1454833 - Keyboard shortcuts do not work on hangouts.google.com in strict keypress event dipatching mode

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[imyxhuang]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:61.0) Gecko/20100101 Firefox/61.0
Build ID: 20180416133911

Steps to reproduce:

1. Download Nightly version 61.0a1.en-linux-x86-64 from the Mozilla site or install via firefox-trunk PPA, on Ubuntu 17.10.
2. Sign in to https://mail.google.com/mail/u/0/#inbox


Actual results:

None of Gmail's keyboard shortcuts work, including "c" to compose a new email, "/" to search, and shortcuts such as Ctrl+B in the Hangouts windows below merely activate Firefox's shortcuts to view the bookmarks sidebar, etc.


Expected results:

https://drive.google.com/drive/my-drive seems to have shortcuts working properly. For example, "j" and "k" can select folders down and up.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to imyxhuang from comment #0)
> Actual results:
> 
> None of Gmail's keyboard shortcuts work, including "c" to compose a new
> email, "/" to search, and shortcuts such as Ctrl+B in the Hangouts windows
> below merely activate Firefox's shortcuts to view the bookmarks sidebar, etc.

Ah, I need to turn on keyboard shortcut in Gmail settings to use those shortcut keys.

However, I don't reproduce about "c", "/". I reproduced only Ctrl+B on Hanguots window since it's a sub-document loaded from hangouts.google.com.

Are you sure to reproduce the former issue? How about in safe mode?

Comment 2

[imyxhuang]

Oh, I'm silly, I didn't turn on shortcut keys either. I assumed it was all of Gmail but only noticed it because of Hangouts. I think I'll close this bug and add a comment to bug 1440189 regarding Hangouts (since that should be a quick fix), unless you have a better idea to tidy this up.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

No, we should add hangouts.google.com to the blacklist from this bug.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d7b1c809ebd48955af5e954f8de8bea6a91ec083

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1454833 - Allow to use legacy keypress event behavior in hangouts.google.com

hangouts.google.com is used Hangouts in Gmail window.  In this window, shortcut
keys are handled with keypress event for Gecko.  Therefore, we need to add
hangouts.google.com into the blacklist.

Review commit: https://reviewboard.mozilla.org/r/237556/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/237556/

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8968825 [details]
Bug 1454833 - Allow to use legacy keypress event behavior in hangouts.google.com

https://reviewboard.mozilla.org/r/237556/#review244550

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8968825 [details]
Bug 1454833 - Allow to use legacy keypress event behavior in hangouts.google.com

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/237556/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f63f20404c55
Allow to use legacy keypress event behavior in hangouts.google.com r=smaug

Comment 9

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/f63f20404c55

Comment 10

[Kohei Yoshino [:kohei]]

Updated the site compatibility note: https://www.fxsitecompat.com/en-CA/docs/2018/non-printable-keys-will-soon-stop-firing-keypress-event/