Closed Bug 1454853 Opened 6 years ago Closed 6 years ago

Update Debugger Frontend v40

Categories

(DevTools :: Debugger, enhancement, P3)

enhancement

Tracking

(firefox61 fixed)

RESOLVED FIXED
Firefox 61
Tracking Status
firefox61 --- fixed

People

(Reporter: jlast, Assigned: jlast)

References

Details

Attachments

(1 file, 1 obsolete file)

Assignee: nobody → jlaster
Priority: -- → P3
Attached patch rel-40.patch (obsolete) — Splinter Review
Attachment #8968751 - Flags: review?(jdescottes)
Attached patch rel-40-1.patchSplinter Review
Attachment #8968751 - Attachment is obsolete: true
Attachment #8968751 - Flags: review?(jdescottes)
Attachment #8968757 - Flags: review?(jdescottes)
Comment on attachment 8968757 [details] [diff] [review]
rel-40-1.patch

Review of attachment 8968757 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, just a missing skip-if

talos at https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=9c16256b7a3f4dc4fd6e7943c877bd48bc76531a&newProject=try&newRevision=0aefc10265eec042bb5154d4612db9667dcd5208&framework=1

::: devtools/client/debugger/new/test/mochitest/browser.ini
@@ -144,5 @@
>  
>  [browser_dbg-asm.js]
>  [browser_dbg-async-stepping.js]
>  [browser_dbg-babel-breakpoint-console.js]
> -skip-if = (os == "win" && ccov) # Bug 1453549

missing sync
Attachment #8968757 - Flags: review?(jdescottes) → review+
Pushed by jlaster@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/88c2097bdad0
Update Debugger Frontend v40. r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/88c2097bdad0
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.