1454876 - Install marionette.* preferences on Fennec/Android

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, enhancement)

Description

[Andreas Tolfsen ❲:ato❳]

The marionette.* preference branch defined in
testing/marionette/prefs/marionette.js is only added in toolkit to
Firefox.  We should also have these on Fennec.

Comment 1

[Andreas Tolfsen ❲:ato❳]

This shouldn’t be hard to fix.

Comment 2

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1454876 - Correct marionette.enabled pref doc.

The documentation for the marionette.enabled preference is wrong: it
claims that it is used for disabling the Marionette XPCOM component,
but in reality it starts and stops the TCP server.

Review commit: https://reviewboard.mozilla.org/r/237536/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/237536/

Comment 3

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1454876 - Make it possible to compile Firefox without Marionette.

Marionette is only built when ENABLE_MARIONETTE is defined, but
we unconditionally include its resources in Firefox' packaging
instructions.  These resources ought to be guarded with the same
rule to actually make it possible to disable Marionette without
breaking the packaging.

We already do this on Fennec, see
mobile/android/installer/package-manifest.in:373.

Review commit: https://reviewboard.mozilla.org/r/237538/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/237538/

Comment 4

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1454876 - Install marionette.* prefs on Fennec.

The marionette.* preference branch, defined in
testing/marionette/prefs/marinoette.js, controls aspects of the
Gecko remote control protocol.  Whilst Marionette is not enabled in
optimised Fennec builds, we are apparently missing these preferences
when it is built in.

The marionette.enabled preference specifically enables the remote
server to listen on a TCP port, but its default is false.

Review commit: https://reviewboard.mozilla.org/r/237540/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/237540/

Comment 5

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8968810 [details]
Bug 1454876 - Install marionette.* prefs on Fennec.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/237540/diff/1-2/

Comment 6

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8968808 [details]
Bug 1454876 - Correct marionette.enabled pref doc.

https://reviewboard.mozilla.org/r/237536/#review243350

Comment 7

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8968809 [details]
Bug 1454876 - Make it possible to compile Firefox without Marionette.

https://reviewboard.mozilla.org/r/237538/#review243352

Question: Are Firefox releases built with ENABLE_MARIONETTE=1?

Comment 8

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8968810 [details]
Bug 1454876 - Install marionette.* prefs on Fennec.

https://reviewboard.mozilla.org/r/237540/#review243356

Comment 9

[:Gijs (he/him)]

Comment on attachment 8968809 [details]
Bug 1454876 - Make it possible to compile Firefox without Marionette.

https://reviewboard.mozilla.org/r/237538/#review243358

rs=me

Comment 10

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8968810 [details]
Bug 1454876 - Install marionette.* prefs on Fennec.

https://reviewboard.mozilla.org/r/237540/#review243398

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b5003c282430
Correct marionette.enabled pref doc. r=maja_zf
https://hg.mozilla.org/integration/autoland/rev/e6796949f9b5
Make it possible to compile Firefox without Marionette. r=Gijs,maja_zf
https://hg.mozilla.org/integration/autoland/rev/dae5b0150266
Install marionette.* prefs on Fennec. r=maja_zf,snorp

Comment 12

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/b5003c282430
https://hg.mozilla.org/mozilla-central/rev/e6796949f9b5
https://hg.mozilla.org/mozilla-central/rev/dae5b0150266