Allow toolbox to call getProcess when debugging a localTab

RESOLVED FIXED in Firefox 61

Status

enhancement
P3
normal
RESOLVED FIXED
Last year
Last year

People

(Reporter: jdescottes, Assigned: ladybenko)

Tracking

(Blocks 1 bug)

unspecified
Firefox 61
Dependency tree / graph

Firefox Tracking Flags

(firefox61 fixed)

Details

Attachments

(1 attachment)

See https://bugzilla.mozilla.org/show_bug.cgi?id=1445197#c44 to https://bugzilla.mozilla.org/show_bug.cgi?id=1445197#c46

Currently, a toolbox debugging a local tab has a debugger server with allowChromeProcess set to false. This prevents us from retrieving child process actors which are needed in order to completely list all the currently running service workers. 

The goal of this bug is to flip the allowChromeProcess to true in TabTarget::makeRemote

https://searchfox.org/mozilla-central/rev/f65d7528e34ef1a7665b4a1a7b7cdb1388fcd3aa/devtools/client/framework/target.js#404-407
See Also: → 1445197
As discussed earlier, assigned to you Belén :) 

Let me know if you have any question, :jryans will probably be the best reviewer for this patch.
Assignee: nobody → balbeza
Status: NEW → ASSIGNED
Here are some steps to validate that we solve the issue raised in Bug 1445197.

- build with the patches from Bug 1445197 
  `hg pull -r 0c4b59df5b3e413cd436a2769ddbf4db1326f490 https://reviewboard-hg.mozilla.org/gecko`
- go to about:config
- set devtools.application.enabled to true
- go to https://serviceworke.rs/offline-fallback_demo.html
- open DevTools > Application Panel
  (you should see one worker listed for "serviceworke.rs/offline-fallback/")
- if it is not started, start the worker
- click on the Debug link next to "Source service-worker.js"
- in the toolbox that opens, go to the Debugger, and set a breakpoint on L18 of service-worker.js
  `var request = event.request;`
- reload the page

=> currently the breakpoint is not hit, 
   with the patch you should hit the breakpoint

Comment 4

Last year
mozreview-review
Comment on attachment 8969342 [details]
Bug 1454895 - allow toolbox to call getProcess when debugging a local tab.

https://reviewboard.mozilla.org/r/238078/#review243788

Thanks, this looks good to me. :) I feel like I should apologize for target.js a bit...  It's quite a mess these days.  Hopefully it is not too discouraging to see such a crazy module...  We plan to rework it extensively as part of Fission work, so ideally it will less crazy soon.
Attachment #8969342 - Flags: review?(jryans) → review+
Assignee

Updated

Last year
Keywords: checkin-needed

Comment 5

Last year
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e93f256f7159
allow toolbox to call getProcess when debugging a local tab. r=jryans
Keywords: checkin-needed

Comment 6

Last year
bugherder
https://hg.mozilla.org/mozilla-central/rev/e93f256f7159
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61

Updated

Last year
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.