Closed Bug 1454941 Opened 6 years ago Closed 6 years ago

TRR: revert bug 1451150, use NS_CAPTIVE_PORTAL_CONNECTIVITY for both "captive" and "clear" the same

Categories

(Core :: Networking: DNS, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: bagder, Assigned: bagder)

Details

(Whiteboard: [necko-triaged][trr])

Attachments

(1 file)

I had misunderstood the code in bug 1451150 so it wrongly crippled the wait-for-portal logic.

The observer topic NS_CAPTIVE_PORTAL_CONNECTIVITY gets "clear" when it was never in a CP and it gets "captive" when it has been. For the TRR logic, the distinction isn't important and we should act the same for both.
Comment on attachment 8968887 [details]
bug 1454941 - revert CP wait fix from bug 1451150

https://reviewboard.mozilla.org/r/237620/#review243332
Attachment #8968887 - Flags: review?(valentin.gosu) → review+
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.