Closed
Bug 1454956
Opened 6 years ago
Closed 6 years ago
Change scheme loops in nsIOService.cpp to use range-based loops (clang-tidy: modernize-loop-convert )
Categories
(Core :: Networking, defect, P5)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: Gijs, Assigned: Gijs)
References
Details
(Whiteboard: [necko-triaged])
Attachments
(1 file)
This came up in bug 1447341, but unfortunately the reviewbot only came in after the push, and didn't review the original csets (unsure why). Anyway, this should be easy to fix.
|
||
Comment 1•6 years ago
|
||
The solution for this can be found in https://bugzilla.mozilla.org/show_bug.cgi?id=1447341#c21
|
||
Updated•6 years ago
|
Whiteboard: [good first bug][lang=c++] → [good first bug][lang=c++][necko-triaged]
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 3•6 years ago
|
||
(In reply to Johann Hofmann [:johannh] from comment #1) > The solution for this can be found in > https://bugzilla.mozilla.org/show_bug.cgi?id=1447341#c21 Oh pff, sorry, I didn't realize you were making this a good-first-bug, I hadn't seen bugmail for this. :-(
Mentor: jhofmann
Keywords: good-first-bug
Whiteboard: [good first bug][lang=c++][necko-triaged] → [necko-triaged]
|
|
||
Comment 4•6 years ago
|
||
Ah, no worries, I just noticed you hadn't assigned yourself. We have plenty other good first bugs around :)
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Comment on attachment 8969369 [details] Bug 1454956 - change scheme loop to use a range-based for loop, https://reviewboard.mozilla.org/r/238118/#review243858
Attachment #8969369 -
Flags: review?(hurley) → review+
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/69008e17de66 change scheme loop to use a range-based for loop, r=nwgh
|
||
Comment 7•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/69008e17de66
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•