Closed Bug 1454987 Opened 6 years ago Closed 6 years ago

[MIPS32] Enable cmpPtrSet overload that takes ImmWord

Categories

(Core :: JavaScript Engine: JIT, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: dragan.mladjenovic, Assigned: dragan.mladjenovic)

Details

Attachments

(1 file)

      No description provided.
Attached patch bug1454987.patchSplinter Review
See https://searchfox.org/mozilla-central/source/js/src/jit/mips32/MacroAssembler-mips32-inl.h#696 for more context.
Assignee: nobody → dragan.mladjenovic
Attachment #8968934 - Flags: review?(bbouvier)
Comment on attachment 8968934 [details] [diff] [review]
bug1454987.patch

Review of attachment 8968934 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thanks!
Attachment #8968934 - Flags: review?(bbouvier) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/15b7d9b0d059
[MIPS32] Enable cmpPtrSet overload that takes ImmWord. r=bbouvier
Keywords: checkin-needed
Priority: -- → P5
https://hg.mozilla.org/mozilla-central/rev/15b7d9b0d059
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.