Closed Bug 1455016 Opened 2 years ago Closed 2 years ago

[MIPS64] Fix potentially undefined result of rotateLeft64

Categories

(Core :: JavaScript Engine: JIT, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: dragan.mladjenovic, Assigned: dragan.mladjenovic)

Details

Attachments

(1 file)

No description provided.
Attached patch bug1455016.patchSplinter Review
The rotateLeft64(ma_drol) count register can contain arbitrary 64-bit value, so using negu(subu) instruction on it could result in an undefined value. This patch replaces negu with explicit dsubu to avoid that.
Assignee: nobody → dragan.mladjenovic
Attachment #8968957 - Flags: review?(bbouvier)
Summary: [MIPS64] Fix potentially undefined behavior of rotateLeft64 → [MIPS64] Fix potentially undefined result of rotateLeft64
Priority: -- → P5
Comment on attachment 8968957 [details] [diff] [review]
bug1455016.patch

Review of attachment 8968957 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thanks!
Attachment #8968957 - Flags: review?(bbouvier) → review+
Keywords: checkin-needed
Pushed by btara@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8bd01029ff4e
[MIPS64] Fix potentially undefined behavior of rotateLeft64; r=bbouvier
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f93d567284f7
[MIPS64] Fix potentially undefined behavior of rotateLeft64. r=bbouvier
https://hg.mozilla.org/mozilla-central/rev/8bd01029ff4e
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.