Closed
Bug 1455025
Opened 6 years ago
Closed 6 years ago
Cleanup some private methods in WorkerPrivate.h
Categories
(Core :: DOM: Workers, enhancement, P2)
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: baku, Assigned: baku)
References
Details
Attachments
(1 file)
3.87 KB,
patch
|
asuth
:
review+
|
Details | Diff | Splinter Review |
There are no reasons to have NotifyPrivate() and PostMessageToParentInternal().
Assignee | ||
Comment 1•6 years ago
|
||
Attachment #8968968 -
Flags: review?(bugmail)
Updated•6 years ago
|
Priority: -- → P2
Comment 2•6 years ago
|
||
Comment on attachment 8968968 [details] [diff] [review] cleanup.patch Review of attachment 8968968 [details] [diff] [review]: ----------------------------------------------------------------- Restating: Bug 1435263 got rid of the separate WorkerPrivateParent<WorkerPrivate> class which provided a logically distinct "class for parent-thread exposed stuff" and accordingly resulted in some redirection. These changes are leftover cleanup from that bug. PS: Good cleanup/thanks for the cleanup!
Attachment #8968968 -
Flags: review?(bugmail) → review+
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/1c46524d2fbf Cleanup some private methods in WorkerPrivate.h, r=asuth
Comment 4•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1c46524d2fbf
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•