Closed Bug 1455035 Opened 3 years ago Closed 3 years ago

Telemetry throws errors when using share item because we forgot to update the categories for the page action items

Categories

(Firefox :: Address Bar, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 61
Tracking Status
firefox61 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

References

Details

Attachments

(1 file)

https://searchfox.org/mozilla-central/rev/f65d7528e34ef1a7665b4a1a7b7cdb1388fcd3aa/toolkit/components/telemetry/Histograms.json#6293-6342

For all of these items, we need to add a key for the 'share' item. We need to add it at the end of the list like we did with the search engine addition one because of telemetry Reasons.
Sorry for not catching this in review. :-(
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Comment on attachment 8968981 [details]
Bug 1455035 - add shareURL support to page action histograms,

https://reviewboard.mozilla.org/r/237686/#review243630

Yeh I didnt know about this, thanks for fixing
Attachment #8968981 - Flags: review?(dharvey) → review+
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/3ae765ce2b28
add shareURL support to page action histograms, r=daleharvey
Priority: -- → P1
https://hg.mozilla.org/mozilla-central/rev/3ae765ce2b28
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
You need to log in before you can comment on or make changes to this bug.