1455059 - Tab no longer works in Etherpad

Status: RESOLVED WORKSFORME

(Web Compatibility :: Site Reports, defect, P1)

Description

[Pascal Chevrel:pascalc (PTO until April 26)]

Mozilla/5.0 (X11; Linux x86_64; rv:61.0) Gecko/20100101 Firefox/61.0 ID:20180418112600

STR:
1/ Go to https://public.etherpad-mozilla.org/p/testkeypress
2/ go to some line of text, hit the Tab key.

ER:
Line gets indented like in 59 or Chrome

AR:
Nothing happens

This is a regression reported by our Nightly community today on IRC.

Comment 1

[Michael Kohler [:mkohler]]

Just noticed I have a really old nightly on my personal laptop. So I can say: the regression range is somewhere between 2018-04-07 and today.

Comment 2

[Pascal Chevrel:pascalc (PTO until April 26)]

Last good revision: d10dc4dc4162b15320bf468adaf5cf0859666c23
First bad revision: 2ab582bacc98fecfc3cc52b3f275a23ff40a683f
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=d10dc4dc4162b15320bf468adaf5cf0859666c23&tochange=2ab582bacc98fecfc3cc52b3f275a23ff40a683f

Caused by bug 1440189

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Hmm, first, we should report Etherpad developers this bug to fix by their side.

Until actually fixed, we need to add some hack for Etherpad...

Comment 4

[Brian Birtles (:birtles, Feb 26~ parental leave)]

List of public instances of etherpad lite:

https://github.com/ether/etherpad-lite/wiki/Sites-that-run-Etherpad-Lite

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Filed issue to Etherpad:
https://github.com/ether/etherpad-lite/issues/3383

Comment 6

[Kohei Yoshino [:kohei]]

Updated the site compatibility note: https://www.fxsitecompat.com/en-CA/docs/2018/non-printable-keys-will-soon-stop-firing-keypress-event/

Comment 7

[Ryan VanderMeulen [:RyanVM]]

This behavior change is currently Nightly-only.

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

This works for me in Nightly 63 and Beta 62, on macOS 10.13.5.  Pascal, is it still broken for you?

Comment 9

[Brian Birtles (:birtles, Feb 26~ parental leave)]

We've turned off the new behavior for that site using the dom.keyboardevent.keypress.hack.dispatch_non_printable_keys pref.

We've since fixed the code upstream but have yet to get Mozilla's instance of Etherpad updated. Once we do that, we can drop it from the blacklist in that pref.

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

The tab key appears to work for Mozilla's instance and for others, for example, https://beta.etherpad.org/p/testingtab.