1455081 - update the dark theme color for --newtab-text-tertiary-color and --newtab-icon-tertiary-color

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement, P2)

Description

[Ricky Rosario [:rrosario, :r1cky]]

> can we change the tertiary colour to Grey 10 @60% (also icon too to match).

Comment 1

[Ricky Rosario [:rrosario, :r1cky]]

And for --newtab-icon-tertiary-color in dark theme:

> Dark theme - Use Grey 10 at 20% for icons (pin, context clue). I wouldn’t change the default theme

Comment 2

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Ricky Rosario [:rrosario, :r1cky] from comment #1)
> And for --newtab-icon-tertiary-color in dark theme:
> 
> > Dark theme - Use Grey 10 at 20% for icons (pin, context clue). I wouldn’t change the default theme

NVM, make that....

> Dark theme - Use Grey 10 at 40% for icons (pin, context clue)
> Yeah the context text can stay at 60%.
> Just change the tertiary icon colour to Grey 10 40%
> I swear no more colour changes to the text after that

lies ;)

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4106

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/dc3235e3c0f4c4c511bb269e42fdf0cea95361a9
Fix Bug 1455081 - update icon and text tertiary colors in dark theme

https://github.com/mozilla/activity-stream/commit/9339e04f9dd0cb5ac1b1e3c105cfd00a7ddd9ec8
Merge pull request #4106 from rlr/Bug1455081/tertiary-color

Fix Bug 1455081 - update icon and text tertiary colors in dark theme

Comment 5

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/5d2486077e4b