Support subdialog sizing of HTML documents from a stylesheet and use it for autofill edit dialogs

RESOLVED FIXED in Firefox 61

Status

()

enhancement
P1
normal
RESOLVED FIXED
Last year
Last year

People

(Reporter: MattN, Assigned: MattN)

Tracking

Trunk
Firefox 61
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox61 fixed)

Details

(Whiteboard: [webpayments])

Attachments

(1 attachment)

Setting width/max-width on `html` or `body` from a stylesheet for a HTML document  doesn't currently work for sizing the subdialog which means that @width or @style="width: NNNpx" on `html` is necessary. That works okay except that it means that it requires allowing inline styles via CSP which isn't great since you can't allow only certain properties.

For Web Payments we re-use editAddress.xhtml and editCreditCard.xhtml outside of the subdialog in the PaymentRequest dialog and want to have a strict CSP to prevent inline styles so we currently get CSP errors on every load.

Checking the scrollWidth on the body (for HTML documents, where the <body> exists) works.
Comment on attachment 8969124 [details]
Bug 1455151 - Support subdialog sizing of HTML documents from a stylesheet and use it for autofill edit dialogs.

https://reviewboard.mozilla.org/r/237836/#review243560
Attachment #8969124 - Flags: review?(jaws) → review+
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/b180b277a1ef
Support subdialog sizing of HTML documents from a stylesheet and use it for autofill edit dialogs. r=jaws
https://hg.mozilla.org/mozilla-central/rev/b180b277a1ef
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
You need to log in before you can comment on or make changes to this bug.